Skip to content

fix: update fox positioning #30310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025
Merged

fix: update fox positioning #30310

merged 2 commits into from
Feb 14, 2025

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Feb 13, 2025

Description

Follow up fix for this PR

Issue: This PR was merged just after the logo package update in this PR which caused some issues with the positioning of the fox. The positioning was calculated on the old fox package

Solution: Update camera position as well as fox.json position

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Fresh install of the extension app
  2. Go through wallet creation or import wallet - check to see if fox is in correct position
  3. Check lock screen to make sure the fox is in right position

Screenshots/Recordings

NA

Before

Screen.Recording.2025-02-13.at.2.55.53.PM.mov

After

Screen.Recording.2025-02-13.at.3.19.34.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🦊

  • Checked onboarding fox head ✅
  • Checked lock screen fox head ✅
  • Checked storybook fox head ✅

@gambinish
Copy link
Contributor

Pulled & tested, lgtm

@vinnyhoward vinnyhoward added this pull request to the merge queue Feb 13, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [92da2fc]
Page Load Metrics (1611 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23918101465393189
domContentLoaded14161935159012359
load14251939161112359
domInteractive16102382210
backgroundConnect991282311
firstReactRender13101412814
getState46714189
initialActions01000
loadScripts988131911398742
setupStore7491194
uiStartup16352273184015675
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2 Bytes (0.00%)
  • common: 68 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@vinnyhoward vinnyhoward added this pull request to the merge queue Feb 13, 2025
@vinnyhoward vinnyhoward removed this pull request from the merge queue due to a manual request Feb 13, 2025
@vinnyhoward vinnyhoward added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 99f5b19 Feb 14, 2025
86 checks passed
@vinnyhoward vinnyhoward deleted the fix-fox-positioning branch February 14, 2025 00:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
@metamaskbot metamaskbot added release-12.14.0 Issue or pull request that will be included in release 12.14.0 release-12.13.0 Issue or pull request that will be included in release 12.13.0 and removed release-12.14.0 Issue or pull request that will be included in release 12.14.0 labels Feb 14, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-12.13.0 on PR. Adding release label release-12.13.0 on PR and removing other release labels(release-12.14.0), as PR was added to branch 12.13.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants