-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: update fox positioning #30310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update fox positioning #30310
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🦊
- Checked onboarding fox head ✅
- Checked lock screen fox head ✅
- Checked storybook fox head ✅
Pulled & tested, lgtm |
Builds ready [92da2fc]
Page Load Metrics (1611 ± 59 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Missing release label release-12.13.0 on PR. Adding release label release-12.13.0 on PR and removing other release labels(release-12.14.0), as PR was added to branch 12.13.0 when release was cut. |
Description
Follow up fix for this PR
Issue: This PR was merged just after the logo package update in this PR which caused some issues with the positioning of the fox. The positioning was calculated on the old fox package
Solution: Update camera position as well as
fox.json
positionRelated issues
Fixes:
Manual testing steps
Screenshots/Recordings
NA
Before
Screen.Recording.2025-02-13.at.2.55.53.PM.mov
After
Screen.Recording.2025-02-13.at.3.19.34.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist