chore: bump @metamask/base-controller to ^8.0.0
#30251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
cryptodev-2s
force-pushed
the
cryptodev2s/bump-base-controller-v8
branch
from
0f1ad33 to
bc03b12
Compare
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Builds ready [9a6f95b]
Page Load Metrics (1788 ± 62 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Mrtenz
reviewed
Feb 12, 2025
| @@ -19,6 +19,7 @@ export const CronjobControllerInit: ControllerInitFunction< | |||
| // with the expected type. | |||
| // TODO: Look into the type mismatch. | |||
| state: persistedState.CronjobController, | |||
| // @ts-expect-error TODO: Resolve mismatch between base-controller versions. | |||
There was a problem hiding this comment.
Property '#private' in type 'RestrictedMessenger' refers to a different member that cannot be accessed from within type 'RestrictedMessenger'.
This error often occurs when there’s a major version mismatch in base-controller. It will be resolved once we upgrade the controller. In the meantime, we’re using the @ts-ignore rule to accommodate the new base-controller version.
Mrtenz
approved these changes
Feb 12, 2025
ccharly
approved these changes
Feb 12, 2025
matthewwalsh0
approved these changes
Feb 12, 2025
metamaskbot
added
the
release-12.13.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps
@metamask/base-controllerfrom^7.0.0to^8.0.0.Major changes on version v8 is removal of
BaseControllerV1and oldmessengeraliases. CHANGELOGOther minor bumps to align with
@metamask/base-controllerversion (mostly package version updates).@metamask/accounts-controllerfrom^23.0.0to^23.0.1CHANGELOG@metamask/address-book-controllerfrom^6.0.0to^6.0.3CHANGELOG@metamask/announcement-controllerfrom^7.0.0to^7.0.3CHANGELOG@metamask/ens-controllerfrom^15.0.0to^15.0.2CHANGELOG@metamask/gas-fee-controllerfrom^22.0.1to^22.0.3CHANGELOG@metamask/keyring-controllerfrom^19.0.6to^19.0.7CHANGELOG@metamask/logging-controllerfrom^6.0.0to^6.0.4CHANGELOG@metamask/message-managerfrom^12.0.0to^12.0.1CHANGELOG@metamask/multichain-transactions-controllerfrom^0.2.0to^0.3.0CHANGELOG@metamask/name-controllerfrom^8.0.0to^8.0.3CHANGELOG@metamask/notification-services-controllerfrom^0.19.0to^0.20.1CHANGELOG@metamask/permission-controllerfrom^11.0.0to^11.0.6CHANGELOG@metamask/permission-log-controllerfrom^3.0.1to^3.0.1CHANGELOG@metamask/phishing-controllerfrom^12.3.0to^12.3.2CHANGELOG@metamask/polling-controllerfrom^12.0.1to^12.0.3CHANGELOG@metamask/profile-sync-controllerfrom^6.0.0to^7.0.1CHANGELOG@metamask/rate-limit-controllerfrom^6.0.2to^6.0.3CHANGELOG@metamask/user-operation-controllerfrom^24.0.0to^24.0.1CHANGELOG@metamask/preferences-controllerfrom^15.0.1to^15.0.2CHANGELOGRelated issues
Fixes: #30248, #30155
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist