Skip to content

feat: Add Unichain Mainnet ID and Logo #30234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

cbachmeier
Copy link

@cbachmeier cbachmeier commented Feb 10, 2025

Description

  • Add Unichain ID: 130
  • Add Network logo for Unichain and Unichain Sepolia
  • Use ETH Token Logo for Unichain and Unichain Sepolia

Open in GitHub Codespaces

Related issues

Fixes:N/A

Manual testing steps

  1. Go to app.uniswap.org
  2. Connect w/ Metamask
  3. Open In-App Wallet Settings in the right hand menu
  4. Enable Unichain Beta
  5. Attempt to Swap on Unichain Mainnet
  6. Add Unichain to Metamask Networks

Screenshots/Recordings

Before

Screenshot 2025-02-10 at 14 00 31

After

Screenshot 2025-02-10 at 14 03 57

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 10, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cbachmeier
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@metamaskbot metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 10, 2025
@cbachmeier cbachmeier marked this pull request as ready for review February 10, 2025 21:03
@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 10, 2025
@cbachmeier cbachmeier changed the title Add Unichain Mainnet ID and Logo feat: Add Unichain Mainnet ID and Logo Feb 11, 2025
@salimtb salimtb enabled auto-merge February 14, 2025 09:56
@salimtb salimtb disabled auto-merge February 14, 2025 09:56
@salimtb
Copy link
Contributor

salimtb commented Feb 17, 2025

as the CI is keep failing for this one , i created a new one here

@cbachmeier cbachmeier closed this Feb 17, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants