fix: corrupted tokens state

[salimtb]

Description

Balances should be displayed on the swap from picker

core PR: MetaMask/core#5257

Related issues

Fixes: #30040

Manual testing steps

1. Choose popular network on the network tokens filter
2. Click on swap button
3. balances should be displayed on the from and to picker

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [2533ea7]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1561 ± 52 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	426	1761	1495	260	125
		domContentLoaded	1403	1842	1543	105	51
		load	1411	1893	1561	109	52
		domInteractive	23	81	39	21	10
		backgroundConnect	9	92	27	22	10
		firstReactRender	15	67	29	20	10
		getState	4	53	16	17	8
		initialActions	0	1	0	0	0
		loadScripts	1002	1372	1112	85	41
		setupStore	7	85	27	26	13
		uiStartup	1639	2192	1801	177	85

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 4.5 KiB (0.08%)
• ui: 0 Bytes (0.00%)
• common: 20 Bytes (0.00%)

[metamaskbot]

Builds ready [3e25c4f]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1617 ± 37 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	368	1755	1559	284	136
		domContentLoaded	1431	1712	1596	78	37
		load	1489	1758	1617	78	37
		domInteractive	23	73	33	13	6
		backgroundConnect	10	65	24	18	9
		firstReactRender	15	89	44	28	13
		getState	4	59	11	14	7
		initialActions	0	1	0	0	0
		loadScripts	1032	1244	1128	71	34
		setupStore	8	57	11	11	5
		uiStartup	1652	2283	1839	141	68

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 4.52 KiB (0.08%)
• ui: 0 Bytes (0.00%)
• common: 20 Bytes (0.00%)

[Prithpal-Sooriya]

Should we also update the .mjs file as well for webpack builds?

[salimtb]

usually updating the cjs file is enough when we create patch

[Prithpal-Sooriya]

Hmm as long as this passes CI (webpack builds use mjs).

I'm guessing we will release a new version soon.

[sleepytanya]

Still reproducing for both Current and Popular network views:

zero_balance.mov

[darkwing]

1️⃣ What was the issue?

The token list was not refreshing correctly.

2️⃣ Why did it happen and why wasn’t it caught earlier?

Refresh issue appeared to be caused by a missing dependency in the useEffect, suggesting that it was an existing bug.

3️⃣ What actions are we taking to prevent this in the future?

Fix was merged.

4️⃣ Any related tickets and ETAs for follow-up actions?

• We should update an existing E2E to check for displayed balance.