Skip to content

chore: Rename ControllerMessenger to Messenger #30041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Jan 31, 2025

Description

Rename RestrictedControllerMessenger to RestrictedMessenger and ControllerMessenger to Messenger.

No functional changes.

Open in GitHub Codespaces

Related issues

Fixes:

Relates to #4538

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [178b7ce]
Page Load Metrics (1676 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14642037167716278
domContentLoaded14531990164315273
load14642041167615976
domInteractive237935178
backgroundConnect1081322010
firstReactRender1576322311
getState45918189
initialActions01000
loadScripts10331417118511354
setupStore75718188
uiStartup16252249188918287
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -20 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (for accounts owned files).

Copy link
Member

@OGPoyraz OGPoyraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmation changes looks good.

@cryptodev-2s cryptodev-2s added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit 2af746e Feb 3, 2025
70 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/use-renamed-messenger branch February 3, 2025 16:48
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants