feat: account tag enhancement & uppercase for OneKey labels #29999

Akaryatrh · 2025-01-30T09:25:45Z

Description

This PR adds support for a dedicated OneKey keyring (until now it was sharing the same keyring instance than Trezor) so it's considered as a standalone device and could get its own tag inside account list.

There are two others PRs:

eth-trezor-package: feat: add dedicated OneKey keyring class accounts#175
Core (account and keyring controllers): feat: add new keyring type for oneKey core#5216

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/793

Manual testing steps

You need both OneKey and Trezor devices to test. Trezor device can be replaced by this simulator.
⚠️ Simulator takes over other devices, you need to disconnect first it if you import a OneKey account.

Import one account from Trezor device.
Check that it gets the "Trezor" tag below account name in account list
Import one account from OneKey device
Check that it gets the "OneKey" tag below account name in account list and that account name matches the pattern "OneKey x"

Screenshots/Recordings

Before

onekey-before.mp4

After

onekey-after.mp4

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-30T09:25:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2025-01-30T09:26:47Z

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

Akaryatrh · 2025-02-07T14:59:07Z

ui/pages/create-account/connect-hardware/account-list.js

@@ -50,7 +50,7 @@ class AccountList extends Component {
        <div className="hw-connect__hdPath">
          <Dropdown
            className="hw-connect__hdPath__select"
-            options={hdPaths[device.toLowerCase()]}
+            options={hdPaths[device]}


Setting device name to lowercase would fail checking hdPaths for device with camel case naming. So far, there's apparently no need to do so for other devices.

Akaryatrh · 2025-02-07T15:00:17Z

app/scripts/metamask-controller.js

-        keyringBridge?.minorVersion === ONE_KEY_VIA_TREZOR_MINOR_VERSION
-          ? HardwareKeyringType.oneKey
-          : HardwareKeyringType[keyringType],
+      ({ type }) => HardwareKeyringType[type],


No need anymore to rely on ONE_KEY_VIA_TREZOR_MINOR_VERSION as OneKey gets its own keyring type.

app/scripts/metamask-controller.js

This PR adds support for a dedicated OneKey keyring (until now it was sharing the same keyring instance than Trezor) so it's considered as a standalone device and could get its own tag inside account list. There are two others PRs: - metamask-extension: MetaMask/metamask-extension#29999 - core (accounts and keyring controllers): MetaMask/core#5216 Fixes: MetaMask/accounts-planning#793

## Explanation This PR adds support for a dedicated OneKey keyring (until now it was sharing the same keyring instance than Trezor) so it's considered as a standalone device and could get its own tag inside account list. There are two others PRs: - metamask-extension: MetaMask/metamask-extension#29999 - eth-trezor-keyring: MetaMask/accounts#175 ## References Fixes: MetaMask/accounts-planning#793 ## Changelog  ### `@metamask/accounts-controller` - **utils**: add OneKey keyring type - **tests**: update accounts controller unit test with OneKey keyring type ### `@metamask/keyring-controller` - **controller**: add OneKey keyring type ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Akaryatrh · 2025-02-12T15:29:17Z

@metamaskbot update-policies

metamaskbot · 2025-02-12T15:42:05Z

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

metamaskbot · 2025-02-12T16:22:30Z

Builds ready [0519154]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1677 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1460	2016	1679	131	63
		domContentLoaded	1450	2002	1660	127	61
		load	1462	2014	1677	127	61
		domInteractive	23	108	41	23	11
		backgroundConnect	11	56	19	11	5
		firstReactRender	16	107	38	28	13
		getState	5	68	22	24	11
		initialActions	0	1	0	0	0
		loadScripts	1035	1437	1194	105	51
		setupStore	8	72	25	23	11
		uiStartup	1721	2708	1987	238	114

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.13 KiB (0.02%)
ui: 75 Bytes (0.00%)
common: 1.17 KiB (0.01%)

ui/pages/create-account/connect-hardware/account-list.js

metamaskbot · 2025-02-17T11:40:30Z

Builds ready [0a6bdec]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1872 ± 88 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1593	2274	1873	181	87
		domContentLoaded	1548	2215	1846	181	87
		load	1595	2280	1872	183	88
		domInteractive	25	75	37	14	7
		backgroundConnect	10	67	31	21	10
		firstReactRender	16	72	31	22	11
		getState	5	69	16	19	9
		initialActions	0	1	0	0	0
		loadScripts	1090	1687	1339	156	75
		setupStore	8	58	19	18	8
		uiStartup	1762	2579	2143	221	106

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.13 KiB (0.02%)
ui: 75 Bytes (0.00%)
common: 1.37 KiB (0.01%)

metamaskbot · 2025-02-19T21:29:59Z

Builds ready [71aeb1c]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2081 ± 136 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	474	2629	1999	448	215
		domContentLoaded	1498	2606	2052	277	133
		load	1509	2637	2081	284	136
		domInteractive	17	122	50	33	16
		backgroundConnect	9	106	36	26	13
		firstReactRender	15	83	42	26	12
		getState	5	53	22	18	8
		initialActions	0	1	0	0	0
		loadScripts	1091	1992	1547	227	109
		setupStore	6	69	20	19	9
		uiStartup	1913	3147	2418	336	161

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 599 Bytes (0.01%)
ui: 75 Bytes (0.00%)
common: 44 Bytes (0.00%)

metamaskbot · 2025-02-19T22:25:26Z

Builds ready [3b41bf8]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1685 ± 53 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	284	1981	1618	327	157
		domContentLoaded	1509	1916	1658	102	49
		load	1530	1978	1685	111	53
		domInteractive	24	93	38	22	11
		backgroundConnect	8	79	32	20	10
		firstReactRender	14	91	31	25	12
		getState	5	66	21	21	10
		initialActions	0	1	0	0	0
		loadScripts	1089	1395	1197	87	42
		setupStore	7	71	27	24	12
		uiStartup	1723	2342	1929	164	79

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 526 Bytes (0.01%)
ui: 75 Bytes (0.00%)
common: 44 Bytes (0.00%)

metamaskbot · 2025-02-20T13:14:49Z

Builds ready [64da565]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1522 ± 64 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	500	1635	1447	227	109
		domContentLoaded	1386	2022	1501	132	64
		load	1406	2026	1522	133	64
		domInteractive	21	97	33	19	9
		backgroundConnect	8	75	23	19	9
		firstReactRender	13	93	31	25	12
		getState	4	52	12	15	7
		initialActions	0	1	0	0	0
		loadScripts	970	1643	1082	139	67
		setupStore	6	77	14	18	8
		uiStartup	1574	2248	1748	149	72

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 526 Bytes (0.01%)
ui: 75 Bytes (0.00%)
common: 44 Bytes (0.00%)

mikesposito

Since we use the same Keyring as Trezor (and even the same bridge), do you think we can take advantage of Trezor e2e tests as well?

Akaryatrh · 2025-03-04T09:31:51Z

Since we use the same Keyring as Trezor (and even the same bridge), do you think we can take advantage of Trezor e2e tests as well?

@mikesposito Yep definitely, we need to plan it on a separate pull request 👍

metamaskbot · 2025-03-04T10:10:29Z

Builds ready [48cae93]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1667 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1488	1906	1660	126	60
		domContentLoaded	1435	1896	1621	123	59
		load	1493	1907	1667	123	59
		domInteractive	17	85	35	17	8
		backgroundConnect	15	178	52	39	19
		firstReactRender	14	67	31	21	10
		getState	6	63	20	16	8
		initialActions	0	1	0	0	0
		loadScripts	1043	1370	1199	94	45
		setupStore	8	54	14	12	6
		uiStartup	1696	2140	1896	143	69

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 526 Bytes (0.01%)
ui: 75 Bytes (0.00%)
common: 44 Bytes (0.00%)

metamaskbot · 2025-03-13T09:15:41Z

Builds ready [c828db9]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2310 ± 252 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1747	3663	2261	407	196
		domContentLoaded	1731	2613	2125	233	112
		load	1748	4158	2310	525	252
		domInteractive	26	173	45	31	15
		backgroundConnect	16	1361	174	304	146
		firstReactRender	17	221	54	55	26
		getState	6	456	79	118	57
		initialActions	0	0	0	0	0
		loadScripts	1294	1872	1601	160	77
		setupStore	8	170	37	46	22
		uiStartup	1996	8690	3049	1520	730

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 203 Bytes (0.00%)
ui: 75 Bytes (0.00%)
common: 44 Bytes (0.00%)

ui/pages/create-account/connect-hardware/account-list.js

metamaskbot · 2025-03-14T15:12:13Z

Builds ready [9549f08]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (6499 ± 3971 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	379	31661	5336	7643	3670
		domContentLoaded	1669	31617	6089	8367	4018
		load	1742	31667	6499	8269	3971
		domInteractive	27	1258	209	335	161
		backgroundConnect	59	1428	384	387	186
		firstReactRender	21	383	83	81	39
		getState	16	1383	224	321	154
		initialActions	0	1	0	0	0
		loadScripts	1253	31185	5491	8384	4026
		setupStore	9	585	98	137	66
		uiStartup	1933	31839	8150	8103	3891

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 203 Bytes (0.00%)
ui: 68 Bytes (0.00%)
common: 44 Bytes (0.00%)

ui/pages/create-account/connect-hardware/account-list.js

metamaskbot · 2025-03-14T19:45:08Z

Builds ready [9bc12b1]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (6304 ± 3477 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	473	24248	6157	7312	3511
		domContentLoaded	1727	24161	6058	7208	3461
		load	1807	24254	6304	7242	3477
		domInteractive	27	1742	236	404	194
		backgroundConnect	21	980	264	254	122
		firstReactRender	23	164	59	37	18
		getState	14	347	93	84	40
		initialActions	0	1	0	0	0
		loadScripts	1291	23727	5424	7085	3402
		setupStore	7	142	37	36	17
		uiStartup	2082	24503	7259	6997	3360

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 203 Bytes (0.00%)
ui: 35 Bytes (0.00%)
common: 44 Bytes (0.00%)

ccharly

Code LGTM, haven't tested since I don't have neither devices. Also, assuming the removal of .toLowerCase won't have undesired side-effects 😄 (but I'd say no)

Akaryatrh · 2025-03-17T11:01:43Z

Code LGTM, haven't tested since I don't have neither devices. Also, assuming the removal of .toLowerCase won't have undesired side-effects 😄 (but I'd say no)

Thanks! I just tested ledger, Trezor, OneKey and Lattice devices and could not see any regression.

metamaskbot · 2025-03-19T09:52:34Z

Builds ready [b599f0b]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (2409 ± 1280 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1414	14314	2414	2779	1335
		domContentLoaded	1361	13678	2292	2654	1274
		load	1370	13797	2409	2666	1280
		domInteractive	25	760	84	164	79
		backgroundConnect	10	630	128	168	81
		firstReactRender	15	127	49	32	15
		getState	5	299	62	83	40
		initialActions	0	1	0	0	0
		loadScripts	992	12066	1799	2400	1152
		setupStore	8	198	42	52	25
		uiStartup	1620	14747	2890	2865	1376

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 203 Bytes (0.00%)
ui: 35 Bytes (0.00%)
common: 44 Bytes (0.00%)

gantunesr

Looks good!

dawnseeker8

LGTM after Gustova and Charly review

Akaryatrh added the team-hardware-wallets label Jan 30, 2025

Akaryatrh commented Feb 7, 2025

View reviewed changes

app/scripts/metamask-controller.js Show resolved Hide resolved

This was referenced Feb 7, 2025

feat: add new keyring type for oneKey MetaMask/core#5216

Merged

feat: add dedicated OneKey keyring class MetaMask/accounts#175

Merged

Akaryatrh force-pushed the feat/793-oneKey-dedicated-keyring branch 2 times, most recently from 8989dc1 to 0c19260 Compare February 12, 2025 15:24

Akaryatrh marked this pull request as ready for review February 13, 2025 12:31

Akaryatrh commented Feb 13, 2025

View reviewed changes

ui/pages/create-account/connect-hardware/account-list.js Outdated Show resolved Hide resolved

Akaryatrh force-pushed the feat/793-oneKey-dedicated-keyring branch from 0a6bdec to e6a980d Compare February 19, 2025 15:05

Akaryatrh force-pushed the feat/793-oneKey-dedicated-keyring branch from e3791ae to 3b41bf8 Compare February 19, 2025 21:50

mikesposito reviewed Feb 20, 2025

View reviewed changes

vivek-consensys added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 21, 2025

Akaryatrh requested a review from mikesposito March 12, 2025 09:37

Akaryatrh and others added 2 commits March 12, 2025 12:29

feat: account tag enhancement & uppercase for OneKey labels

790690b

Update LavaMoat policies

a7916cf

feat: remove useless OneKey constant

3bdbc76

Akaryatrh force-pushed the feat/793-oneKey-dedicated-keyring branch from 48cae93 to 3bdbc76 Compare March 12, 2025 11:42

fix: wrong dep version after rebase

a55dbcc

Akaryatrh force-pushed the feat/793-oneKey-dedicated-keyring branch from 11194aa to a55dbcc Compare March 12, 2025 11:46

Merge branch 'main' into feat/793-oneKey-dedicated-keyring

c828db9

ccharly reviewed Mar 14, 2025

View reviewed changes

ui/pages/create-account/connect-hardware/account-list.js Outdated Show resolved Hide resolved

feat: simplify lowercase mapping comparison

9549f08

Akaryatrh force-pushed the feat/793-oneKey-dedicated-keyring branch from af5b03c to 9549f08 Compare March 14, 2025 14:33

ccharly reviewed Mar 14, 2025

View reviewed changes

ui/pages/create-account/connect-hardware/account-list.js Outdated Show resolved Hide resolved

Akaryatrh force-pushed the feat/793-oneKey-dedicated-keyring branch from 38feb39 to 9bc12b1 Compare March 14, 2025 19:08

ccharly previously approved these changes Mar 17, 2025

View reviewed changes

feat: finally remove lowercase check

1cb2ae5

Akaryatrh dismissed ccharly’s stale review via 1cb2ae5 March 17, 2025 10:57

Akaryatrh force-pushed the feat/793-oneKey-dedicated-keyring branch from 9bc12b1 to 1cb2ae5 Compare March 17, 2025 10:57

Merge branch 'main' into feat/793-oneKey-dedicated-keyring

b599f0b

gantunesr approved these changes Mar 20, 2025

View reviewed changes

dawnseeker8 approved these changes Mar 21, 2025

View reviewed changes

github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Mar 21, 2025

Akaryatrh added this pull request to the merge queue Mar 21, 2025

Merged via the queue into main with commit 0fcdd45 Mar 21, 2025
76 checks passed

Akaryatrh deleted the feat/793-oneKey-dedicated-keyring branch March 21, 2025 11:02

github-actions bot locked and limited conversation to collaborators Mar 21, 2025

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 21, 2025

metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: account tag enhancement & uppercase for OneKey labels #29999

feat: account tag enhancement & uppercase for OneKey labels #29999

Akaryatrh commented Jan 30, 2025 •

edited

Loading

github-actions bot commented Jan 30, 2025

socket-security bot commented Jan 30, 2025 •

edited

Loading

Akaryatrh Feb 7, 2025

Akaryatrh Feb 7, 2025

Akaryatrh commented Feb 12, 2025

metamaskbot commented Feb 12, 2025

metamaskbot commented Feb 12, 2025

metamaskbot commented Feb 17, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 20, 2025

mikesposito left a comment

Akaryatrh commented Mar 4, 2025 •

edited

Loading

metamaskbot commented Mar 4, 2025

metamaskbot commented Mar 13, 2025

metamaskbot commented Mar 14, 2025

metamaskbot commented Mar 14, 2025

ccharly left a comment

Akaryatrh commented Mar 17, 2025

metamaskbot commented Mar 19, 2025

gantunesr left a comment

dawnseeker8 left a comment

feat: account tag enhancement & uppercase for OneKey labels #29999

feat: account tag enhancement & uppercase for OneKey labels #29999

Conversation

Akaryatrh commented Jan 30, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 30, 2025

socket-security bot commented Jan 30, 2025 • edited Loading

Akaryatrh Feb 7, 2025

Choose a reason for hiding this comment

Akaryatrh Feb 7, 2025

Choose a reason for hiding this comment

Akaryatrh commented Feb 12, 2025

metamaskbot commented Feb 12, 2025

metamaskbot commented Feb 12, 2025

metamaskbot commented Feb 17, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 19, 2025

metamaskbot commented Feb 20, 2025

mikesposito left a comment

Choose a reason for hiding this comment

Akaryatrh commented Mar 4, 2025 • edited Loading

metamaskbot commented Mar 4, 2025

metamaskbot commented Mar 13, 2025

metamaskbot commented Mar 14, 2025

metamaskbot commented Mar 14, 2025

ccharly left a comment

Choose a reason for hiding this comment

Akaryatrh commented Mar 17, 2025

metamaskbot commented Mar 19, 2025

gantunesr left a comment

Choose a reason for hiding this comment

dawnseeker8 left a comment

Choose a reason for hiding this comment

Akaryatrh commented Jan 30, 2025 •

edited

Loading

socket-security bot commented Jan 30, 2025 •

edited

Loading

Akaryatrh commented Mar 4, 2025 •

edited

Loading