Skip to content

feat: Update RPC URL check for smart transactions on BNB chain #29922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Jan 27, 2025

Description

Updates RPC URL check for smart transactions on BNB chain.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Get the branch and run yarn dist
  2. In the /builds folder you will see a .zip file with the extension after its done
  3. Install it in Google Chrome
  4. When smart transactions are turned on (by default) and you submit a Send or Swap transaction on the BNB chain, it will be submitted as a smart transaction

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-transactions Transactions team label Jan 27, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [890ace4]
Page Load Metrics (1633 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14331958163613163
domContentLoaded14241940161013364
load14331962163313062
domInteractive219437209
backgroundConnect104921126
firstReactRender1574382512
getState55114157
initialActions01000
loadScripts10091505117912861
setupStore660202010
uiStartup16582580189120799
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 10 Bytes (0.00%)

@dan437 dan437 added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 3db2064 Jan 27, 2025
74 checks passed
@dan437 dan437 deleted the skip-rpc-url-check-for-bnb-chain branch January 27, 2025 16:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants