add test case #29885
Merged
add test case #29885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Merged
7 tasks
jiexi
reviewed
Jan 23, 2025
jiexi
reviewed
Jan 23, 2025
| decimals: 18, | ||
| }, | ||
| // this does not match what already exists in the NetworkController as an endpoint for this chain | ||
| rpcUrls: ['http://127.0.0.1:8546'], |
There was a problem hiding this comment.
you can use localhost here i think and keep it on 8545
jiexi
reviewed
Jan 23, 2025
| .build(), | ||
| ganacheOptions: { | ||
| ...defaultGanacheOptions, | ||
| concurrent: [{ port: 8546, chainId: '0x539' }], |
There was a problem hiding this comment.
don't think you need double ganache nor the second ganache instance since you can target localhost and 127.0.0.1 for the singular 0x539 ganache instance
Co-authored-by: jiexi <[email protected]>
jiexi
approved these changes
Jan 23, 2025
adonesky1
merged commit a686e2b
into
jl/mmp-3814/fix-grant-permissions-add-ethereum-chain
36 of 44 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing test case