-
Notifications
You must be signed in to change notification settings - Fork 5.2k
test: Fix invalid fixture builder #29783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Gudahtt
merged 1 commit into
main
from
remove-non-existent-accounts-from-permission-fixture-builders
Jan 17, 2025
Merged
test: Fix invalid fixture builder #29783
Gudahtt
merged 1 commit into
main
from
remove-non-existent-accounts-from-permission-fixture-builders
Jan 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two of the permission fixture builders were adding permissions for accounts that do not exist. They have been updated to only grant permissions for the selected account, which is the only account guaranteed to exist in the default fixture.
adonesky1
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7 tasks
Gudahtt
commented
Jan 17, 2025
@@ -594,10 +591,7 @@ class FixtureBuilder { | |||
caveats: [ | |||
{ | |||
type: 'restrictReturnedAccounts', | |||
value: [ | |||
'0x5cfe73b6021e818b776b421b1c4db2474086a7e1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the default selected account. I can update this in a separate PR to use the variable here instead.
Builds ready [6ecf015]
Page Load Metrics (1610 ± 87 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
jiexi
approved these changes
Jan 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.12.0
Issue or pull request that will be included in release 12.12.0
team-extension-platform
Extension Platform team
team-wallet-api-platform
team-wallet-framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two of the permission fixture builders were adding permissions for accounts that do not exist. They have been updated to only grant permissions for the selected account, which is the only account guaranteed to exist in the default fixture.
Related issues
This was extracted from #27847
Manual testing steps
See that E2E tests still pass
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist