fix: remove supported chains check #29773

vinistevam · 2025-01-17T08:55:26Z

Description

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3940

Manual testing steps

Go to the test dapp
Perform transactions and signatures in the section PPOM - Malicious Transactions and Signatures
Test one previous supported chain and another chain outside the list below:

// previous supported chains
ARBITRUM = '0xa4b1'
AVALANCHE = '0xa86a'
BASE = '0x2105'
BERACHAIN = '0x138d4'
BSC = '0x38'
LINEA_MAINNET = '0xe708'
MAINNET = '0x1'
METACHAIN_ONE = '0x1b6e6'
OPBNB = '0xcc'
OPTIMISM = '0xa'
POLYGON = '0x89'
SCROLL = '0x82750'
SEPOLIA = '0xaa36a7'
ZKSYNC_ERA = '0x144'

Screenshots/Recordings

Screencast.from.2025-01-28.14-56-38.webm

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-17T08:55:37Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-01-28T11:36:57Z

Builds ready [d5b9e39]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1917 ± 161 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	358	2553	1831	470	226
		domContentLoaded	1499	2493	1892	328	157
		load	1532	2555	1917	335	161
		domInteractive	24	178	57	36	17
		backgroundConnect	9	80	34	23	11
		firstReactRender	16	177	53	39	18
		getState	5	101	30	28	14
		initialActions	0	1	0	0	0
		loadScripts	1049	1932	1396	269	129
		setupStore	7	101	17	21	10
		uiStartup	1721	3227	2253	457	219

Bundle size diffs [🚀 Bundle size reduced!]

background: -491 Bytes (-0.01%)
ui: 0 Bytes (0.00%)
common: -826 Bytes (-0.01%)

metamaskbot · 2025-01-31T08:37:18Z

Builds ready [efede98]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1833 ± 89 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	248	2304	1440	667	320
		domContentLoaded	1545	2235	1810	179	86
		load	1549	2307	1833	186	89
		domInteractive	27	90	36	14	7
		backgroundConnect	8	73	26	18	9
		firstReactRender	16	94	47	27	13
		getState	4	69	21	21	10
		initialActions	0	0	0	0	0
		loadScripts	1096	1692	1334	154	74
		setupStore	8	61	20	18	9
		uiStartup	1822	2603	2144	241	116

Bundle size diffs [🚀 Bundle size reduced!]

background: -491 Bytes (-0.01%)
ui: 0 Bytes (0.00%)
common: -826 Bytes (-0.01%)

metamaskbot · 2025-02-17T13:46:26Z

Builds ready [dd76041]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1545 ± 71 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1345	1838	1551	139	67
		domContentLoaded	1334	1811	1514	138	66
		load	1343	1840	1545	148	71
		domInteractive	22	75	40	20	10
		backgroundConnect	8	191	39	43	21
		firstReactRender	13	68	27	20	10
		getState	4	13	7	2	1
		initialActions	0	1	0	0	0
		loadScripts	959	1311	1088	98	47
		setupStore	7	61	15	17	8
		uiStartup	1516	2112	1749	178	85

Bundle size diffs [🚀 Bundle size reduced!]

background: -491 Bytes (-0.01%)
ui: 0 Bytes (0.00%)
common: -826 Bytes (-0.01%)

metamaskbot · 2025-02-18T06:52:44Z

Builds ready [3e9ea7b]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1595 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1388	1980	1598	165	79
		domContentLoaded	1361	1970	1577	166	80
		load	1370	1981	1595	168	81
		domInteractive	23	103	39	21	10
		backgroundConnect	9	55	21	14	7
		firstReactRender	14	92	41	27	13
		getState	4	67	11	15	7
		initialActions	0	0	0	0	0
		loadScripts	949	1444	1134	143	69
		setupStore	6	62	18	20	10
		uiStartup	1548	2459	1877	239	115

Bundle size diffs [🚀 Bundle size reduced!]

background: -491 Bytes (-0.01%)
ui: 0 Bytes (0.00%)
common: -826 Bytes (-0.01%)

metamaskbot · 2025-02-18T11:39:21Z

Builds ready [d66c8a8]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1865 ± 74 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1628	2267	1865	153	74
		domContentLoaded	1587	2211	1834	144	69
		load	1626	2268	1865	153	74
		domInteractive	26	72	38	11	5
		backgroundConnect	9	69	32	21	10
		firstReactRender	15	95	41	27	13
		getState	4	99	25	26	12
		initialActions	0	1	0	0	0
		loadScripts	1135	1664	1324	118	56
		setupStore	8	65	19	18	9
		uiStartup	1838	2852	2190	237	114

Bundle size diffs [🚀 Bundle size reduced!]

background: -491 Bytes (-0.01%)
ui: 0 Bytes (0.00%)
common: -826 Bytes (-0.01%)

fix: remove supported chains check

b653fe4

vinistevam added the team-confirmations Push issues to confirmations team label Jan 17, 2025

Merge branch 'main' into fix/remove-supported-chains-check-ppom

c73c35a

vinistevam marked this pull request as ready for review January 27, 2025 13:29

vinistevam requested a review from a team as a code owner January 27, 2025 13:29

fix: unit tests

770c98d

vinistevam force-pushed the fix/remove-supported-chains-check-ppom branch from d1b80a2 to 770c98d Compare January 27, 2025 14:10

vinistevam added 2 commits January 27, 2025 14:29

fix: lint unit test

6c0d03b

fix: e2e tests

748ed7c

vinistevam force-pushed the fix/remove-supported-chains-check-ppom branch from 4c3fcf1 to 748ed7c Compare January 28, 2025 10:29

Merge branch 'main' into fix/remove-supported-chains-check-ppom

d5b9e39

vinistevam added 2 commits January 30, 2025 14:19

Merge branch 'main' into fix/remove-supported-chains-check-ppom

d255a9e

Merge branch 'main' into fix/remove-supported-chains-check-ppom

efede98

vinistevam added 2 commits February 17, 2025 08:46

Merge branch 'main' into fix/remove-supported-chains-check-ppom

48eae8e

Merge branch 'main' into fix/remove-supported-chains-check-ppom

dd76041

vinistevam added 2 commits February 17, 2025 15:45

Merge branch 'main' into fix/remove-supported-chains-check-ppom

282af7c

Merge branch 'main' into fix/remove-supported-chains-check-ppom

3e9ea7b

jpuri approved these changes Feb 18, 2025

View reviewed changes

pedronfigueiredo approved these changes Feb 18, 2025

View reviewed changes

Merge branch 'main' into fix/remove-supported-chains-check-ppom

d66c8a8

vinistevam enabled auto-merge February 18, 2025 11:25

vinistevam added this pull request to the merge queue Feb 18, 2025

Merged via the queue into main with commit b5f4f0f Feb 18, 2025
73 checks passed

vinistevam deleted the fix/remove-supported-chains-check-ppom branch February 18, 2025 12:10

github-actions bot locked and limited conversation to collaborators Feb 18, 2025

metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove supported chains check #29773

fix: remove supported chains check #29773

vinistevam commented Jan 17, 2025 •

edited

Loading

github-actions bot commented Jan 17, 2025

metamaskbot commented Jan 28, 2025

metamaskbot commented Jan 31, 2025

metamaskbot commented Feb 17, 2025

metamaskbot commented Feb 18, 2025

metamaskbot commented Feb 18, 2025

fix: remove supported chains check #29773

fix: remove supported chains check #29773

Conversation

vinistevam commented Jan 17, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 17, 2025

metamaskbot commented Jan 28, 2025

metamaskbot commented Jan 31, 2025

metamaskbot commented Feb 17, 2025

metamaskbot commented Feb 18, 2025

metamaskbot commented Feb 18, 2025

vinistevam commented Jan 17, 2025 •

edited

Loading