-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat: Enable BSC for smart transactions #29747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
klejeune
previously approved these changes
Jan 17, 2025
antonydenyer
previously approved these changes
Jan 17, 2025
Builds ready [f44d86c]
Page Load Metrics (1794 ± 78 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [89c7b31]
Page Load Metrics (1748 ± 65 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
antonydenyer
approved these changes
Jan 17, 2025
infiniteflower
approved these changes
Jan 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-transactions
release-12.12.0
Issue or pull request that will be included in release 12.12.0
team-transactions
Transactions team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables BSC for smart transactions and reduces status check time to 1s.
We can turn off BSC support for smart transactions remotely if needed.
Related issues
Fixes:
Manual testing steps
Happy paths tested for Swaps, Send and dapp transactions, but this will require extensive testing before it goes to production.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist