fix: remove segmented tab on confirm import modal #29720

matteoscurati · 2025-01-15T09:52:28Z

Description

This PR removes the segmented tab on the confirm import token modal as described in this issue: #26788

Related issues

#26788

Manual testing steps

Start the procedure to import a token
Confirm the token to be imported
On the confirmation page, the tab should no longer be visible

Screenshots/Recordings

Before

After

https://www.loom.com/share/b3a522ccf9974c06a73ea6236db89cc6?sid=b56a3ed9-6a06-4a23-8ed1-eecc1fa73d8a

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-15T09:52:41Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-01-15T10:28:51Z

Builds ready [9689292]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1871 ± 118 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	332	2247	1790	418	201
		domContentLoaded	1488	2238	1840	249	120
		load	1541	2251	1871	246	118
		domInteractive	16	65	33	11	5
		backgroundConnect	7	76	30	24	11
		firstReactRender	15	79	37	23	11
		getState	5	61	16	14	7
		initialActions	0	1	0	0	0
		loadScripts	1118	1749	1375	202	97
		setupStore	7	63	18	18	8
		uiStartup	1756	2553	2154	268	129

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-01-16T15:24:34Z

Builds ready [6087f49]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1659 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	455	1786	1593	274	131
		domContentLoaded	1473	1763	1640	83	40
		load	1478	1796	1659	85	41
		domInteractive	26	85	39	15	7
		backgroundConnect	6	69	17	15	7
		firstReactRender	15	92	36	25	12
		getState	4	70	16	20	10
		initialActions	0	1	0	0	0
		loadScripts	1049	1337	1219	78	37
		setupStore	6	63	14	16	8
		uiStartup	1720	2433	1958	193	93

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-01-20T15:56:12Z

Builds ready [bca3a0c]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1740 ± 154 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	343	3004	1584	513	246
		domContentLoaded	1471	2994	1728	322	154
		load	1479	3007	1740	321	154
		domInteractive	24	64	40	13	6
		backgroundConnect	6	48	13	11	5
		firstReactRender	15	73	35	23	11
		getState	4	51	11	13	6
		initialActions	0	1	0	0	0
		loadScripts	1003	2008	1229	205	99
		setupStore	5	61	10	12	6
		uiStartup	1679	3321	1952	343	165

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

…oken-page

…of github.com:MetaMask/metamask-extension into fix/remove-segmented-tab-on-confirm-import-token-page

metamaskbot · 2025-01-27T17:07:27Z

Builds ready [4711875]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1694 ± 44 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	287	1916	1627	321	154
		domContentLoaded	1519	1908	1678	91	44
		load	1553	1914	1694	91	44
		domInteractive	25	69	36	11	5
		backgroundConnect	8	65	22	17	8
		firstReactRender	16	102	44	29	14
		getState	5	49	10	9	4
		initialActions	0	1	0	0	0
		loadScripts	1056	1405	1214	76	36
		setupStore	8	65	26	23	11
		uiStartup	1730	2682	2014	213	102

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

…oken-page

metamaskbot · 2025-01-30T15:36:27Z

Builds ready [9eb8ca5]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1868 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	231	2111	1731	482	231
		domContentLoaded	1571	2176	1834	154	74
		load	1578	2202	1868	163	78
		domInteractive	27	117	45	23	11
		backgroundConnect	9	80	37	24	12
		firstReactRender	17	98	39	26	13
		getState	5	96	24	24	11
		initialActions	0	1	0	0	0
		loadScripts	1078	1598	1339	137	66
		setupStore	9	90	23	21	10
		uiStartup	1842	2659	2214	229	110

fix: 💄 remove segmented tab on confirm import modal

9689292

matteoscurati self-assigned this Jan 15, 2025

metamaskbot added the team-notifications DEPRECATED: Use "team-assets" instead label Jan 15, 2025

matteoscurati force-pushed the fix/remove-segmented-tab-on-confirm-import-token-page branch from 9e7209a to 9689292 Compare January 27, 2025 15:34

Merge branch 'main' into fix/remove-segmented-tab-on-confirm-import-t…

230a786

…oken-page

matteoscurati marked this pull request as ready for review January 27, 2025 15:43

matteoscurati requested a review from a team as a code owner January 27, 2025 15:43

matteoscurati added 3 commits January 27, 2025 17:11

Merge branch 'main' into fix/remove-segmented-tab-on-confirm-import-t…

16f0679

…oken-page

test: ✅ fix test

6163542

Merge branch 'fix/remove-segmented-tab-on-confirm-import-token-page' …

4711875

…of github.com:MetaMask/metamask-extension into fix/remove-segmented-tab-on-confirm-import-token-page

zone-live approved these changes Jan 28, 2025

View reviewed changes

matteoscurati and others added 3 commits January 29, 2025 17:40

Merge branch 'main' into fix/remove-segmented-tab-on-confirm-import-t…

9fa78c5

…oken-page

Merge branch 'main' into fix/remove-segmented-tab-on-confirm-import-t…

f3ac77b

…oken-page

Merge branch 'main' into fix/remove-segmented-tab-on-confirm-import-t…

9eb8ca5

…oken-page

NidhiKJha approved these changes Jan 30, 2025

View reviewed changes

matteoscurati added this pull request to the merge queue Jan 30, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2025

darkwing added this pull request to the merge queue Feb 3, 2025

Merged via the queue into main with commit 2a81420 Feb 3, 2025
70 checks passed

darkwing deleted the fix/remove-segmented-tab-on-confirm-import-token-page branch February 3, 2025 17:48

github-actions bot locked and limited conversation to collaborators Feb 3, 2025

metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove segmented tab on confirm import modal #29720

fix: remove segmented tab on confirm import modal #29720

matteoscurati commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025

metamaskbot commented Jan 15, 2025

metamaskbot commented Jan 16, 2025

metamaskbot commented Jan 20, 2025

metamaskbot commented Jan 27, 2025

metamaskbot commented Jan 30, 2025

fix: remove segmented tab on confirm import modal #29720

fix: remove segmented tab on confirm import modal #29720

Conversation

matteoscurati commented Jan 15, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 15, 2025

metamaskbot commented Jan 15, 2025

metamaskbot commented Jan 16, 2025

metamaskbot commented Jan 20, 2025

metamaskbot commented Jan 27, 2025

metamaskbot commented Jan 30, 2025

matteoscurati commented Jan 15, 2025 •

edited

Loading