-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat: Add origin throttling modal #29656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Iv1979
approved these changes
Jan 13, 2025
matthewwalsh0
requested changes
Jan 16, 2025
ui/pages/confirmations/components/confirm/footer/origin-throttle-modal.tsx
Show resolved
Hide resolved
ui/pages/confirmations/components/confirm/footer/origin-throttle-modal.tsx
Show resolved
Hide resolved
OGPoyraz
commented
Jan 17, 2025
Builds ready [68df0e0]
Page Load Metrics (1916 ± 104 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
requested changes
Jan 27, 2025
pedronfigueiredo
previously approved these changes
Jan 27, 2025
Builds ready [6755df8]
Page Load Metrics (1582 ± 60 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
requested changes
Feb 8, 2025
## **Description** Cherrypick of #28359 (afa7365) This disables account syncing in v12.7.0 [](https://codespaces.new/MetaMask/metamask-extension/pull/28361?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Mathieu Artu <[email protected]>
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [c10559b]
Page Load Metrics (1731 ± 70 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
approved these changes
Feb 12, 2025
pedronfigueiredo
approved these changes
Feb 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.13.0
Issue or pull request that will be included in release 12.13.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings origin throttling modal functionality which is done in the mobile MetaMask/metamask-mobile#10082
The PR also needs an
ApprovalController
to be updated in order to subscribe theaccepted
andrejected
approvals to handle user rejected approvals.Core PR: MetaMask/core#5127
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3344
First mobile task: https://github.com/MetaMask/MetaMask-planning/issues/1822
Manual testing steps
Screenshots/Recordings
origin.throttling.modal.mov
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist