feat: rls workflow #29646

jake-perkins · 2025-01-10T21:50:04Z

Description

This Change will introduce a new workflow that invokes a set of re-useable shared workflows used across both extension and mobile codebases

Related issues

Fixes:
https://github.com/MetaMask/MetaMask-planning/issues/3641

Manual testing steps

Testing manually using ci/cd runs - example outputs/runs can be viewed here

Example Release Branch PR
#29981

Example Changelog PR
#29982

Sample CI Output Run
https://github.com/MetaMask/metamask-extension/actions/runs/13038614194/job/36375005985

1:15
here's the CI output/run - https://github.com/MetaMask/metamask-extension/actions/runs/13038614194/job/36375005985

Screenshots/Recordings

Before

N/A CICD Only

After

N/A CICD Only

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-10T21:50:14Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-01-10T22:29:08Z

Builds ready [38b9b63]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1686 ± 64 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	216	2071	1554	454	218
		domContentLoaded	1496	2051	1653	130	62
		load	1506	2073	1686	134	64
		domInteractive	25	185	58	47	23
		backgroundConnect	6	86	28	21	10
		firstReactRender	16	75	37	23	11
		getState	5	54	21	18	8
		initialActions	0	1	0	0	0
		loadScripts	1056	1538	1234	119	57
		setupStore	6	47	12	12	6
		uiStartup	1704	2337	1913	140	67

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

socket-security · 2025-01-29T18:48:41Z

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

metamaskbot · 2025-01-30T00:01:59Z

Builds ready [52046f9]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1565 ± 27 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1474	1684	1564	55	27
		domContentLoaded	1460	1647	1541	51	24
		load	1468	1686	1565	56	27
		domInteractive	23	83	44	23	11
		backgroundConnect	8	87	25	23	11
		firstReactRender	15	72	33	23	11
		getState	4	52	10	11	5
		initialActions	0	0	0	0	0
		loadScripts	998	1199	1113	52	25
		setupStore	7	73	17	18	9
		uiStartup	1634	2179	1773	110	53

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-01-30T03:31:56Z

Builds ready [ef8b383]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1496 ± 42 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1382	1717	1503	85	41
		domContentLoaded	1355	1587	1473	73	35
		load	1361	1760	1496	87	42
		domInteractive	22	69	34	16	8
		backgroundConnect	9	174	28	37	18
		firstReactRender	15	83	24	20	10
		getState	4	52	15	17	8
		initialActions	0	1	0	0	0
		loadScripts	967	1160	1078	59	29
		setupStore	6	48	13	13	6
		uiStartup	1547	1917	1697	102	49

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-01-30T20:05:21Z

Builds ready [10f71f9]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1452 ± 46 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1308	1695	1462	93	45
		domContentLoaded	1301	1652	1436	87	42
		load	1309	1699	1452	96	46
		domInteractive	22	79	33	18	9
		backgroundConnect	7	61	19	18	8
		firstReactRender	14	59	22	15	7
		getState	4	45	13	14	7
		initialActions	0	0	0	0	0
		loadScripts	911	1253	1036	86	41
		setupStore	6	83	16	20	9
		uiStartup	1454	2208	1680	174	83

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-01-30T20:57:08Z

Builds ready [6c076f5]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (2563 ± 239 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	401	3558	2169	847	407
		domContentLoaded	1891	3517	2522	485	233
		load	1908	3612	2563	498	239
		domInteractive	26	167	57	33	16
		backgroundConnect	8	160	48	39	19
		firstReactRender	17	103	57	19	9
		getState	6	66	24	18	8
		initialActions	0	8	1	2	1
		loadScripts	1395	2735	1916	410	197
		setupStore	7	48	22	12	6
		uiStartup	2207	4136	2968	597	287

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-02-03T10:02:49Z

Builds ready [e869f8d]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1795 ± 82 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1526	2221	1802	182	87
		domContentLoaded	1513	2134	1778	175	84
		load	1524	2140	1795	172	82
		domInteractive	24	118	44	25	12
		backgroundConnect	14	68	23	15	7
		firstReactRender	16	111	48	30	14
		getState	5	84	22	26	12
		initialActions	0	1	0	0	0
		loadScripts	1089	1612	1306	156	75
		setupStore	8	83	31	25	12
		uiStartup	1689	2977	2132	332	159

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

itsyoboieltr

LGTM!

dbrans

Nice work!

rls workflow

a78a121

metamaskbot added the team-dev-ops DevOps team label Jan 10, 2025

tester workflow

38b9b63

jake-perkins added 7 commits January 27, 2025 13:02

extension workflow test

0242e8f

testing

8f3c3c3

bump-test

418821a

bump

e1f4002

testing

55f9bf2

bump

f092d48

test-plan

4b5f62b

itsyoboieltr changed the title ~~rls workflow~~ feat: rls workflow Jan 29, 2025

jake-perkins added 2 commits January 29, 2025 12:41

test

954a2bf

add dev dep

cd7ef89

jake-perkins and others added 13 commits January 29, 2025 13:06

octo for dev

36eeb73

rls test

2058076

feat: release alignment

5737755

Merge branch 'main' into rls-alignment

45cc09c

rename workflow

eed8e77

try transitive deps for shared workflows

8d896f7

testing

f79efbd

testing w/ npx

573b688

test

a828230

testing

b422382

rls-testing

58ed5b7

rls-testing

8dfc9cc

rls-testing

52046f9

jake-perkins added 6 commits January 29, 2025 19:51

testing

3d09df5

rls

e8bcec2

testing

a749ab9

yarn-testing

eee7105

yarn-test

e90e7a6

test

ef8b383

jake-perkins added 4 commits January 30, 2025 12:36

yarn

32f2f15

temp

6df6780

yarn testing

a2c3928

testing

10f71f9

final rls

6c076f5

jake-perkins and others added 3 commits January 31, 2025 14:27

chore: update cicd to use commit ref

3ff983b

Merge branch 'main' into rls-alignment

9ad2933

Merge branch 'main' into rls-alignment

e869f8d

itsyoboieltr approved these changes Feb 3, 2025

View reviewed changes

itsyoboieltr enabled auto-merge February 3, 2025 12:21

dbrans reviewed Feb 3, 2025

View reviewed changes

dbrans approved these changes Feb 3, 2025

View reviewed changes

itsyoboieltr added this pull request to the merge queue Feb 3, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2025

itsyoboieltr added this pull request to the merge queue Feb 3, 2025

Merged via the queue into main with commit b9d63a4 Feb 3, 2025
70 checks passed

itsyoboieltr deleted the rls-alignment branch February 3, 2025 15:40

github-actions bot locked and limited conversation to collaborators Feb 3, 2025

metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: rls workflow #29646

feat: rls workflow #29646

jake-perkins commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025

metamaskbot commented Jan 10, 2025

socket-security bot commented Jan 29, 2025 •

edited

Loading

metamaskbot commented Jan 30, 2025

metamaskbot commented Jan 30, 2025

metamaskbot commented Jan 30, 2025

metamaskbot commented Jan 30, 2025

metamaskbot commented Feb 3, 2025

itsyoboieltr left a comment

dbrans left a comment

feat: rls workflow #29646

feat: rls workflow #29646

Conversation

jake-perkins commented Jan 10, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 10, 2025

metamaskbot commented Jan 10, 2025

socket-security bot commented Jan 29, 2025 • edited Loading

metamaskbot commented Jan 30, 2025

metamaskbot commented Jan 30, 2025

metamaskbot commented Jan 30, 2025

metamaskbot commented Jan 30, 2025

metamaskbot commented Feb 3, 2025

itsyoboieltr left a comment

Choose a reason for hiding this comment

dbrans left a comment

Choose a reason for hiding this comment

jake-perkins commented Jan 10, 2025 •

edited

Loading

socket-security bot commented Jan 29, 2025 •

edited

Loading