feat: improve xchain swaps slippage settings with decimals and warnings #29617

ghgoodreau · 2025-01-09T20:28:38Z

Description

The slippage settings for xchain transactions was not allowing users to input a decimal (i.e. 0.5%), only whole numbers (0, 1, so on...). It also did not display a warning for low slippage settings. This addresses both by allowing the user to input decimal numbers, and displaying a warning when the custom slippage is set to <0.5% in the settings modal.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1830

Manual testing steps

Go to the xchain swaps transaction preparation page.
Edit slippage settings.
Notice decimals are now allowed, and a warning is displayed with low slippage.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-09T20:28:51Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-01-09T23:47:09Z

Builds ready [25483db]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1627 ± 64 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	245	2052	1571	332	159
		domContentLoaded	1380	2038	1598	131	63
		load	1389	2047	1627	132	64
		domInteractive	24	94	38	21	10
		backgroundConnect	8	76	29	22	11
		firstReactRender	15	70	40	23	11
		getState	5	90	20	21	10
		initialActions	0	1	0	0	0
		loadScripts	1004	1640	1197	127	61
		setupStore	6	52	12	13	6
		uiStartup	1610	2276	1840	157	76

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 291 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-01-10T16:42:03Z

Builds ready [a557648]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1724 ± 46 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	332	1933	1650	317	152
		domContentLoaded	1543	1902	1704	98	47
		load	1609	1936	1724	96	46
		domInteractive	26	319	59	65	31
		backgroundConnect	8	71	22	15	7
		firstReactRender	16	76	34	22	10
		getState	6	55	21	19	9
		initialActions	0	1	0	0	0
		loadScripts	1085	1445	1266	84	40
		setupStore	6	62	17	18	8
		uiStartup	1845	2193	1968	111	53

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 291 Bytes (0.00%)
common: 0 Bytes (0.00%)

infiniteflower

Worked for decimal separator as a period.

Does this work for languages where the decimal separator is a comma?

EDIT: nvm, seems like MM keeps commas for tokens like ETH, and percentage values

EDIT2: eh sometimes ETH is comma separated, sometimes not

metamaskbot · 2025-01-10T17:58:47Z

Builds ready [3b07d96]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1763 ± 74 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	727	2057	1706	262	126
		domContentLoaded	1518	1989	1726	136	65
		load	1523	2054	1763	153	74
		domInteractive	22	121	47	30	15
		backgroundConnect	9	119	40	29	14
		firstReactRender	16	72	27	16	8
		getState	4	85	25	24	11
		initialActions	0	1	0	0	0
		loadScripts	1076	1575	1291	130	63
		setupStore	6	58	18	19	9
		uiStartup	1729	2400	2020	177	85

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 43 Bytes (0.00%)
ui: 359 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-01-10T19:05:33Z

Builds ready [d6d1448]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1995 ± 95 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	238	2464	1745	627	301
		domContentLoaded	1697	2428	1972	189	91
		load	1729	2466	1995	197	95
		domInteractive	23	90	47	19	9
		backgroundConnect	10	63	27	16	7
		firstReactRender	18	82	43	21	10
		getState	6	69	33	23	11
		initialActions	0	1	0	0	0
		loadScripts	1259	1867	1487	156	75
		setupStore	7	56	14	12	6
		uiStartup	1917	2787	2292	217	104

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 359 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2025-01-13T17:59:14Z

Builds ready [1957917]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1605 ± 40 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1505	1774	1618	76	36
		domContentLoaded	1463	1761	1583	75	36
		load	1487	1820	1605	84	40
		domInteractive	24	131	34	23	11
		backgroundConnect	11	65	23	15	7
		firstReactRender	15	95	36	26	13
		getState	4	74	20	21	10
		initialActions	0	0	0	0	0
		loadScripts	1086	1358	1189	66	31
		setupStore	6	72	16	19	9
		uiStartup	1716	2364	1867	141	68

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 359 Bytes (0.00%)
common: 0 Bytes (0.00%)

feat: improve xchain swaps slippage settings with decimals and warnings

63da11d

ghgoodreau added the team-swaps DEPRECATED: Use team-swaps-and-bridge label Jan 9, 2025

ghgoodreau added 2 commits January 9, 2025 16:32

fix: fixes linting and tests

ab6564d

Merge branch 'main' into MMS-1830-slippage-improvements-xchain

25483db

Merge branch 'main' into MMS-1830-slippage-improvements-xchain

a557648

ghgoodreau marked this pull request as ready for review January 10, 2025 16:04

ghgoodreau requested a review from a team as a code owner January 10, 2025 16:04

infiniteflower reviewed Jan 10, 2025

View reviewed changes

fix: allow comma for international decimal separation

3b07d96

infiniteflower approved these changes Jan 10, 2025

View reviewed changes

Merge branch 'main' into MMS-1830-slippage-improvements-xchain

d6d1448

ghgoodreau requested a review from micaelae January 10, 2025 20:54

Merge branch 'main' into MMS-1830-slippage-improvements-xchain

1957917

micaelae approved these changes Jan 13, 2025

View reviewed changes

ghgoodreau enabled auto-merge January 13, 2025 17:54

ghgoodreau added this pull request to the merge queue Jan 13, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2025

ghgoodreau added this pull request to the merge queue Jan 13, 2025

Merged via the queue into main with commit de10c46 Jan 13, 2025
79 checks passed

ghgoodreau deleted the MMS-1830-slippage-improvements-xchain branch January 13, 2025 19:50

github-actions bot locked and limited conversation to collaborators Jan 13, 2025

metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Jan 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: improve xchain swaps slippage settings with decimals and warnings #29617

feat: improve xchain swaps slippage settings with decimals and warnings #29617

ghgoodreau commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025

metamaskbot commented Jan 9, 2025

metamaskbot commented Jan 10, 2025

infiniteflower left a comment •

edited

Loading

metamaskbot commented Jan 10, 2025

metamaskbot commented Jan 10, 2025

metamaskbot commented Jan 13, 2025

feat: improve xchain swaps slippage settings with decimals and warnings #29617

feat: improve xchain swaps slippage settings with decimals and warnings #29617

Conversation

ghgoodreau commented Jan 9, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 9, 2025

metamaskbot commented Jan 9, 2025

metamaskbot commented Jan 10, 2025

infiniteflower left a comment • edited Loading

Choose a reason for hiding this comment

metamaskbot commented Jan 10, 2025

metamaskbot commented Jan 10, 2025

metamaskbot commented Jan 13, 2025

ghgoodreau commented Jan 9, 2025 •

edited

Loading

infiniteflower left a comment •

edited

Loading