Skip to content

fix: Wrong icon for ETH on L2s being displayed on transfer confirmations #29353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Dec 19, 2024

Description

We were inadvertently referencing the network icon map instead of the native token map.

Open in GitHub Codespaces

Related issues

Fixes: #29351

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Dec 19, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Dec 19, 2024
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner December 19, 2024 14:27
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [d13125a]
Page Load Metrics (1652 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1518192116548541
domContentLoaded1507186916268239
load1519191816528541
domInteractive257437168
backgroundConnect96025178
firstReactRender1672342311
getState45211136
initialActions01000
loadScripts1114145412337536
setupStore667202110
uiStartup17402113188610148
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 162 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@pedronfigueiredo pedronfigueiredo added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 22490c3 Dec 19, 2024
83 checks passed
@pedronfigueiredo pedronfigueiredo deleted the pnf/29351 branch December 19, 2024 15:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong icon for ETH on L2s being displayed on transfer confirmations
4 participants