-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: not re-load the whole confirmation when spending cap is changed #29347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
decimals={decimals || '0'} | ||
setIsOpenEditSpendingCapModal={setIsOpenEditSpendingCapModal} | ||
/> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the value above need to wait for pending to go away and not the whole component.
Builds ready [c98aa1c]
Page Load Metrics (1618 ± 68 ms)
Bundle size diffs
|
CLosing the PR as issue is getting fixed by PR #29341 |
Description
Currently almost whole of confirmation page re-loads when updating spending cap. This PR makes fix to load only specific sections when spending cap is updated.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3819
Manual testing steps
Screenshots/Recordings
Screen.Recording.2024-12-19.at.4.39.34.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist