Skip to content

fix: Fix low gas display label in speed-up modal #29277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2024
Merged

fix: Fix low gas display label in speed-up modal #29277

merged 2 commits into from
Dec 17, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 17, 2024

Description

Fix issue that undefined is sometime visible on speedup modal. It was actually visible in edge case when 10% low is less than low estimate.

Related issues

Fixes: #28840

Manual testing steps

  1. Go to test dapp
  2. Submit a transaction with less gas so that it takes longer to complete
  3. Open speedup modal and switch to 10% less gas estimate
  4. You should not see undefined string

Screenshots/Recordings

Screenshot 2024-12-17 at 7 05 58 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested a review from a team as a code owner December 17, 2024 13:42
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Dec 17, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [56bb24d]
Page Load Metrics (1807 ± 120 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29327781722412198
domContentLoaded154927561779251120
load156527721807251120
domInteractive278146189
backgroundConnect76328167
firstReactRender1696493115
getState487242613
initialActions01000
loadScripts115023121354243117
setupStore774212311
uiStartup177030872205351169
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 3 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri enabled auto-merge December 17, 2024 15:07
@metamaskbot
Copy link
Collaborator

Builds ready [f7102f7]
Page Load Metrics (1960 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30922261712604290
domContentLoaded16022206192819996
load16212212196020297
domInteractive26114542713
backgroundConnect987342613
firstReactRender16112573316
getState5117313115
initialActions01000
loadScripts12081678145915876
setupStore798252914
uiStartup186030492408327157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 3 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 18bcad9 Dec 17, 2024
77 checks passed
@jpuri jpuri deleted the gas_display_fix branch December 17, 2024 16:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: undefined value display on speed popover
4 participants