-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: Fix low gas display label in speed-up modal #29277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matthewwalsh0
approved these changes
Dec 17, 2024
vinistevam
approved these changes
Dec 17, 2024
Builds ready [56bb24d]
Page Load Metrics (1807 ± 120 ms)
Bundle size diffs
|
Builds ready [f7102f7]
Page Load Metrics (1960 ± 97 ms)
Bundle size diffs
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-12.11.0
Issue or pull request that will be included in release 12.11.0
team-confirmations
Push issues to confirmations team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue that
undefined
is sometime visible on speedup modal. It was actually visible in edge case when10% low
is less than low estimate.Related issues
Fixes: #28840
Manual testing steps
10% less
gas estimateScreenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist