-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: personal sign message - decode message to UTF-8 string only if it is valid UTF-8 #29232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [439de89]
Page Load Metrics (1636 ± 50 ms)
Bundle size diffs
|
it('returns true for valid UTF-8 string', () => { | ||
expect(isValidUTF8('Hello')).toEqual(true); | ||
expect(isValidUTF8('\xC3\x28')).toEqual(true); | ||
expect(isValidUTF8('😀')).toEqual(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, is it possible to include false
cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep I will include it in following PR
Pull Request is not mergeable
Description
Converts personal sign message to UTF-8 string only if it can be converted to valid UTF-8 string.
Related issues
Fixes: #3931
Manual testing steps
0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist