Skip to content

chore: integrate MultichainBalancesController #28875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 23, 2025

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Dec 3, 2024

Description

This PR changes the current non-EVM BalancesController for the new MultichainBalancesController that is now included in the version 46.0.0 of the @metamask/assets-controllers.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/723
Fixes: #29678

Manual testing steps

  1. Start the Flask wallet
  2. Enable the Bitcoin experimental feature
  3. Add a Bitcoin account (mainnet or testnet)
  4. Check that the balance is correct
  5. Make a transaction (send/receive)
  6. Check that the balance is correct after 10/15 min

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr marked this pull request as ready for review January 21, 2025 18:05
@gantunesr
Copy link
Member Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot metamaskbot requested review from a team as code owners January 21, 2025 18:42
@mostafaadel33

This comment was marked as spam.

darioAnongba
darioAnongba previously approved these changes Jan 22, 2025
ccharly
ccharly previously approved these changes Jan 22, 2025
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested manually too!

@gantunesr gantunesr dismissed stale reviews from ccharly and darioAnongba via 79463ed January 22, 2025 21:04
@gantunesr
Copy link
Member Author

@metamaskbot update-policies

Copy link

socket-security bot commented Jan 22, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected] None +1 2.75 MB metamaskbot

View full report↗︎

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot
Copy link
Collaborator

Builds ready [95b26c5]
Page Load Metrics (1649 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25718411518412198
domContentLoaded1409182616328641
load1417184216498742
domInteractive257342147
backgroundConnect65019168
firstReactRender16100372813
getState55612147
initialActions01000
loadScripts1016136312068139
setupStore66112157
uiStartup16832453192819694
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -33.5 KiB (-0.56%)
  • ui: 307 Bytes (0.00%)
  • common: 79.39 KiB (0.91%)

@ccharly ccharly added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 6a50aba Jan 23, 2025
73 checks passed
@ccharly ccharly deleted the chore/integrate-multichain-balances branch January 23, 2025 09:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update metamask/assets-controllers to version 46.0.0
7 participants