Skip to content

fix: Multichain AssetList unit tests #28451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 93 commits into from
Closed

fix: Multichain AssetList unit tests #28451

wants to merge 93 commits into from

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Nov 13, 2024 •
edited by github-actions bot
Loading

Description

Unit test updates in order to merge multichain feature behind feature flag.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

darkwing and others added 29 commits November 9, 2024 15:31
@darkwing
test: Add E2E tests for multichain asset list and aggregated balances
d3cc84f
@gambinish
chore: Rebase with feature branch
cf98259
@jonybur
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
d0f53f2 
…-balances' of github.com:MetaMask/metamask-extension into e2e-tests-token-list-aggregated-balance
@jonybur
test fixes, bump, lavamoat fix
65c25b1
@jonybur
Fix tests
678ba8c
@jonybur
Test fix
1237c16
@jonybur
Fix test
841aa63
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
de3a412 
…-balances' into e2e-tests-token-list-aggregated-balance
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
ae1ea97 
…-balances' into e2e-tests-token-list-aggregated-balance
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
d215c45 
…-balances' into e2e-tests-token-list-aggregated-balance
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
dedde07 
…-balances' into e2e-tests-token-list-aggregated-balance
@gambinish
Merge branch 'e2e-tests-token-list-aggregated-balance' of github.com:…
d58b91b 
…MetaMask/metamask-extension into e2e-tests-token-list-aggregated-balance
@gambinish
fix: Snapshot update - padding to edit icon gas button
c2b7058
@gambinish
fix: Update snapshots related to pixel padding difference. This may b…
3a2f619 
…e reverted if root cause is found
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
7cec54e 
…-balances' into e2e-tests-token-list-aggregated-balance
@gambinish
fix: After reverting change to component library, reset snapshots to …
2e61dfb 
…previous
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
760dd6a 
…-balances' into e2e-tests-token-list-aggregated-balance
@gambinish
fix: Update snapshots after removing unecessary margin change to Butt…
65bd882 
…onBase
@gambinish
fix: NFTs are now also namespaced to currentChainId
bbc8a2b
@gambinish
fix: Update token cell test, by tweaking primary formatWithThreshold …
fc8e334 
…function signature
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
afd98f6 
…-balances' into e2e-tests-token-list-aggregated-balance
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
f48bc66 
…-balances' into e2e-tests-token-list-aggregated-balance
@gambinish
fix: Update snapshot for token cell after tweak
33dabad
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
3eaed47 
…-balances' into e2e-tests-token-list-aggregated-balance
@gambinish
fix: Update mocked action in network-list-menu.test.js
acc7938
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
a2eafbb 
…-balances' into e2e-tests-token-list-aggregated-balance
@gambinish
chore: update token-list-item snapshot
1dcefd2
@gambinish
fix: Update unit test for token-list-item related to scam warning
9e7d097
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
be5a8e8 
…-balances' into e2e-tests-token-list-aggregated-balance
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@gambinish gambinish marked this pull request as ready for review November 20, 2024 05:40
@gambinish gambinish requested review from a team as code owners November 20, 2024 05:40
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
701734c 
…-balances' into mmassets-432_network-filter-extension--integration-unit-tests
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
25452e6 
…-balances' into mmassets-432_network-filter-extension--integration-unit-tests
@gambinish gambinish mentioned this pull request Nov 20, 2024
Closed
7 tasks
gambinish and others added 11 commits November 20, 2024 10:10
@gambinish
chore: Rebase with feature branch
72cef22
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
9123b5c 
…-balances' into mmassets-432_network-filter-extension--integration-unit-tests
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
7c744ef 
…-balances' into mmassets-432_network-filter-extension--integration-unit-tests
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
4c5425a 
…-balances' into mmassets-432_network-filter-extension--integration-unit-tests
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
2f9eab7 
…-balances' into mmassets-432_network-filter-extension--integration-unit-tests
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
610a15f 
…-balances' into mmassets-432_network-filter-extension--integration-unit-tests
@gambinish
chore: Rebase
d19c07c
@gambinish
Merge branch 'mmassets-432_network-filter-extension--integration-unit…
a6d01ed 
…-tests' of github.com:MetaMask/metamask-extension into mmassets-432_network-filter-extension--integration-unit-tests
@gambinish
fix: Update snapshot for token-cell
312488a
@gambinish
fix: Expect capitalized currency values
5103144
@gambinish
fix: Remove suffix shennanigans from CurrencyDisplay in favor of prev…
0149d7a 
…ious behavior
@gambinish gambinish removed the request for review from a team November 21, 2024 04:20
gambinish and others added 6 commits November 20, 2024 20:35
@gambinish
fix: mockEvm account fiat balance snap
e9f14d0
@gambinish
fix: Unskip test
050d32a
@gambinish
fix: Rebase lint change
0b05574
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
f00b960 
…-balances' into mmassets-432_network-filter-extension--integration-unit-tests
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
198fab7 
…-balances' into mmassets-432_network-filter-extension--integration-unit-tests
@gambinish
Merge branch 'feat/mmassets-432_network-filter-extension--integration…
0c8d83c 
…-balances' into mmassets-432_network-filter-extension--integration-unit-tests
@gambinish gambinish mentioned this pull request Nov 21, 2024
Merged
7 tasks
@gambinish
Copy link
Contributor Author

Closing in favor of #28593

@gambinish gambinish closed this Nov 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
team-assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gambinish @metamaskbot @darkwing @jonybur