Skip to content

fix: Properly ellipsize long token names #28392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Nov 8, 2024

Description

Long token names were not being ellilpsized properly; this PR fixes that issue.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Import token contract 0x1121AcC14c63f3C872BFcA497d10926A6098AAc5 on Mainnet
  2. See super long token list item title
  3. See it properly ellipsized
  4. Hover over to see full name

Screenshots/Recordings

Before

CleanShot 2024-11-08 at 11 42 53@2x

After

SCR-20241108-nquw

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner November 8, 2024 21:26
Copy link
Contributor

github-actions bot commented Nov 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron
Copy link
Contributor

bergeron commented Nov 8, 2024

lgtm. it could use more of the space, but it does ellipsis and show full text on hover

Screenshot 2024-11-08 at 1 30 10 PM

@metamaskbot
Copy link
Collaborator

Builds ready [ae74adc]
Page Load Metrics (1960 ± 119 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32324761772533256
domContentLoaded164724791927240115
load165724831960249119
domInteractive248845199
backgroundConnect874382411
firstReactRender571681083115
getState55616168
initialActions01000
loadScripts11861831141720297
setupStore56116178
uiStartup183827382182261125
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 24 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing enabled auto-merge November 11, 2024 20:03
@darkwing darkwing added this pull request to the merge queue Nov 11, 2024
Merged via the queue into develop with commit 3fedf45 Nov 11, 2024
82 checks passed
@darkwing darkwing deleted the token-list-item-ellipsis branch November 11, 2024 20:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants