-
Notifications
You must be signed in to change notification settings - Fork 5.2k
feat: new tx list filter #28180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new tx list filter #28180
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
09642a8
to
158379d
Compare
de0eff1
to
b5fea31
Compare
b5fea31
to
b337d4f
Compare
b337d4f
to
d575c4c
Compare
85af48c
to
e4afa32
Compare
Builds ready [e4afa32]
Page Load Metrics (1997 ± 62 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
ui/components/app/transaction-list/transaction-list.component.js
Outdated
Show resolved
Hide resolved
ui/components/app/transaction-list/transaction-list.component.js
Outdated
Show resolved
Hide resolved
good find , just resolved |
7df7a09
to
2daebe4
Compare
Builds ready [b8e7204]
Page Load Metrics (1733 ± 71 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled down and tested. Swapped some tokens on Polygon and it correctly showed on the Activity List for both the filtered network and All Networks 👍
I noticed a few things in the code that I think maybe we can clean up a bit. Left some comment, so let me know if you feel the same way!
ui/components/app/transaction-list/transaction-list.component.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, pulled it down and works great. I left some comments
ui/components/app/transaction-list/transaction-list.component.js
Outdated
Show resolved
Hide resolved
ui/components/app/transaction-list/transaction-list.component.js
Outdated
Show resolved
Hide resolved
Builds ready [eea3493]
Page Load Metrics (3197 ± 1140 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
As a part of Portfolio View v1, we want to support filtering by chain for the Activity View. This means that when “All Networks” is selected, it also shows the activity for all networks when Activity tab is selected. When “Curren Network” is selected, it shows the activity only for the current network.
PR for smart transaction controller: MetaMask/smart-transactions-controller#498
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2025-03-19.at.14.12.22.mov
Pre-merge author checklist
Pre-merge reviewer checklist