Skip to content

feat: new tx list filter #28180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
Mar 19, 2025
Merged

feat: new tx list filter #28180

merged 47 commits into from
Mar 19, 2025

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Oct 30, 2024

Description

As a part of Portfolio View v1, we want to support filtering by chain for the Activity View. This means that when “All Networks” is selected, it also shows the activity for all networks when Activity tab is selected. When “Curren Network” is selected, it shows the activity only for the current network.

PR for smart transaction controller: MetaMask/smart-transactions-controller#498

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to the activity page
  2. You should have a drop down menu to filter on networks
  3. when you choose current network , you should see only transaction for current network

Screenshots/Recordings

Before

After

Screen.Recording.2025-03-19.at.14.12.22.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb changed the base branch from develop to feat/mmassets-432_network-filter-extension October 30, 2024 12:45
@salimtb salimtb force-pushed the salim/new-tx-list branch 2 times, most recently from de0eff1 to b5fea31 Compare October 30, 2024 13:00
@salimtb salimtb changed the title Salim/new tx list feat: new tx list filter Oct 30, 2024
Base automatically changed from feat/mmassets-432_network-filter-extension to develop October 30, 2024 16:45
@salimtb salimtb force-pushed the salim/new-tx-list branch 6 times, most recently from 85af48c to e4afa32 Compare October 30, 2024 20:37
@salimtb salimtb marked this pull request as ready for review October 30, 2024 23:19
@salimtb salimtb requested a review from a team as a code owner October 30, 2024 23:19
@metamaskbot
Copy link
Collaborator

Builds ready [e4afa32]
Page Load Metrics (1997 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17962345199912862
domContentLoaded17842242196411053
load17992341199712962
domInteractive249859199
backgroundConnect1099342613
firstReactRender552111043416
getState46816178
initialActions00000
loadScripts1298164114499244
setupStore1296402613
uiStartup20042667224116981
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 72 Bytes (0.00%)
  • ui: 2.55 KiB (0.03%)
  • common: 1.6 KiB (0.02%)

darkwing

This comment was marked as resolved.

@salimtb
Copy link
Contributor Author

salimtb commented Oct 31, 2024

Found a bug here; if you click the transaction, the transaction detail modal comes up; if you click the "View on block explorer" link, the link opens on the currently selected chainId, not the chainId of the transaction.

Screen.Recording.2024-10-31.at.11.40.02.AM.mov

good find , just resolved

@salimtb salimtb requested a review from darkwing October 31, 2024 20:38
@metamaskbot
Copy link
Collaborator

Builds ready [b8e7204]
Page Load Metrics (1733 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15902200173814871
domContentLoaded15412176170914670
load15912205173314871
domInteractive248247178
backgroundConnect969262010
firstReactRender42107822110
getState45716188
initialActions00000
loadScripts11161737126713565
setupStore116621157
uiStartup17452388190915474
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 22 Bytes (0.00%)
  • ui: 2.69 KiB (0.03%)
  • common: 1.59 KiB (0.02%)

Copy link
Contributor

@gambinish gambinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down and tested. Swapped some tokens on Polygon and it correctly showed on the Activity List for both the filtered network and All Networks 👍

I noticed a few things in the code that I think maybe we can clean up a bit. Left some comment, so let me know if you feel the same way!

Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, pulled it down and works great. I left some comments

vinnyhoward
vinnyhoward previously approved these changes Mar 19, 2025
vinnyhoward
vinnyhoward previously approved these changes Mar 19, 2025
gambinish
gambinish previously approved these changes Mar 19, 2025
@salimtb salimtb dismissed stale reviews from gambinish and vinnyhoward via 3c3addf March 19, 2025 18:18
@metamaskbot
Copy link
Collaborator

Builds ready [eea3493]
Page Load Metrics (3197 ± 1140 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint167712992294523791142
domContentLoaded152912912258123931149
load169113000319723741140
domInteractive25315546330
backgroundConnect911720566453217
firstReactRender242331064823
getState3674027218187
initialActions01000
loadScripts109411963191523121110
setupStore1345512610249
uiStartup225113163561129151400
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 781 Bytes (0.01%)
  • ui: 7.33 KiB (0.09%)
  • common: 2.04 KiB (0.02%)

@salimtb salimtb added this pull request to the merge queue Mar 19, 2025
Merged via the queue into main with commit 3d58f4a Mar 19, 2025
76 checks passed
@salimtb salimtb deleted the salim/new-tx-list branch March 19, 2025 20:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
@metamaskbot metamaskbot added the release-12.16.0 Issue or pull request that will be included in release 12.16.0 label Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.16.0 Issue or pull request that will be included in release 12.16.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants