Skip to content

fix: Error handling for the state log download failure #26999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix: Error handling for the state log download failure #26999

merged 1 commit into from
Nov 1, 2024

Conversation

NiranjanaBinoy
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy commented Sep 9, 2024 •
edited by hjetpoluru
Loading

Description

Display error message if the exportAsFile() for state log download in advanced tab in the settings fails.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2875

Manual testing steps

  1. Throw an error artificially in the exportAsFile() state logs download function
  2. Failed to download state log. message is diaplayed

Screenshots/Recordings

Before

Screenshot 2024-11-01 at 10 21 23 AM

After

Screenshot 2024-11-01 at 10 34 37 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NiranjanaBinoy NiranjanaBinoy added the team-extension-platform Extension Platform team label Sep 9, 2024
@NiranjanaBinoy NiranjanaBinoy self-assigned this Sep 9, 2024
@NiranjanaBinoy NiranjanaBinoy requested a review from a team as a code owner September 9, 2024 21:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NiranjanaBinoy NiranjanaBinoy force-pushed the exportAsFile-error-handling branch from fda937f to 413f612 Compare September 9, 2024 21:43
@metamaskbot
Copy link
Collaborator

Builds ready [413f612]
Page Load Metrics (1654 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23219951520448215
domContentLoaded14491987163714067
load14581995165414067
domInteractive14165393215
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 100 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@NiranjanaBinoy NiranjanaBinoy changed the title Error handling for the state log download failure fix: Error handling for the state log download failure Sep 10, 2024
@NiranjanaBinoy NiranjanaBinoy force-pushed the exportAsFile-error-handling branch 2 times, most recently from 17af50a to 66cada3 Compare September 11, 2024 17:42
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [66cada3]
Page Load Metrics (1803 ± 115 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24122381487620298
domContentLoaded151922111783235113
load152722401803239115
domInteractive19152402814
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 100 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.10%. Comparing base (a61b938) to head (66cada3).

Files with missing lines Patch % Lines
...es/settings/advanced-tab/advanced-tab.component.js 0.00% 4 Missing ⚠️
ui/helpers/utils/export-utils.js 50.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #26999      +/-   ##
===========================================
- Coverage    70.11%   70.10%   -0.00%     
===========================================
  Files         1426     1426              
  Lines        49689    49693       +4     
  Branches     13902    13902              
===========================================
+ Hits         34835    34836       +1     
- Misses       14854    14857       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NiranjanaBinoy NiranjanaBinoy force-pushed the exportAsFile-error-handling branch from ded2319 to a2fcbc3 Compare September 18, 2024 19:20
@metamaskbot
Copy link
Collaborator

Builds ready [a2fcbc3]
Page Load Metrics (1863 ± 120 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23425211638523251
domContentLoaded155524491844250120
load156424551863249120
domInteractive16115472713
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 338 Bytes (0.00%)
  • common: 482 Bytes (0.01%)

@NiranjanaBinoy NiranjanaBinoy force-pushed the exportAsFile-error-handling branch from a2fcbc3 to ca4bb74 Compare September 24, 2024 02:07
@metamaskbot
Copy link
Collaborator

Builds ready [ca4bb74]
Page Load Metrics (1780 ± 90 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15762243178318991
domContentLoaded15582226175518890
load15972246178018690
domInteractive21152454019
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 338 Bytes (0.00%)
  • common: 482 Bytes (0.01%)

@metamaskbot
Copy link
Collaborator

Builds ready [9d5ec3d]
Page Load Metrics (1758 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29125421619466224
domContentLoaded15812402172716981
load15912571175819996
domInteractive16185453618
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 389 Bytes (0.01%)
  • common: 482 Bytes (0.01%)

@NiranjanaBinoy NiranjanaBinoy force-pushed the exportAsFile-error-handling branch from 5a5171f to 11ba96f Compare September 26, 2024 15:19
@metamaskbot
Copy link
Collaborator

Builds ready [11ba96f]
Page Load Metrics (1714 ± 59 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33920811651324155
domContentLoaded15892025169011254
load15992098171412459
domInteractive1293372010
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 389 Bytes (0.01%)
  • common: 482 Bytes (0.01%)

@NiranjanaBinoy NiranjanaBinoy force-pushed the exportAsFile-error-handling branch from 0618d42 to 3d626de Compare September 30, 2024 17:52
@metamaskbot
Copy link
Collaborator

Builds ready [3d626de]
Page Load Metrics (1690 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25321201628354170
domContentLoaded14732023165414871
load14852164169016881
domInteractive1899392311
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 389 Bytes (0.01%)
  • common: 482 Bytes (0.01%)

@NiranjanaBinoy NiranjanaBinoy requested review from legobeat and a team September 30, 2024 20:32
@NiranjanaBinoy NiranjanaBinoy force-pushed the exportAsFile-error-handling branch from 3d626de to 5f86e1f Compare October 15, 2024 19:10
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Collaborator

Builds ready [5f86e1f]
Page Load Metrics (1901 ± 78 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint53724851819335161
domContentLoaded16512466186316278
load16692479190116278
domInteractive178245189
backgroundConnect7176423718
firstReactRender46195773517
getState565302311
initialActions01000
loadScripts11892077140017182
setupStore1195292311
uiStartup18772678211019393
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 389 Bytes (0.00%)
  • common: 489 Bytes (0.01%)

DDDDDanica
DDDDDanica previously approved these changes Oct 18, 2024
View reviewed changes
@DDDDDanica
Copy link
Contributor

LGTM ! Let me know when u resolve the conflicts !

@NiranjanaBinoy NiranjanaBinoy force-pushed the exportAsFile-error-handling branch from 5f86e1f to 6c80d61 Compare October 18, 2024 15:12
@metamaskbot
Copy link
Collaborator

Builds ready [6c80d61]
Page Load Metrics (1975 ± 181 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint169929471962329158
domContentLoaded168023691892240115
load169731491975377181
domInteractive17140543014
backgroundConnect97918317685
firstReactRender45266954421
getState4158254220
initialActions00000
loadScripts12511867138817283
setupStore10140373316
uiStartup185039402221529254
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 389 Bytes (0.00%)
  • common: 489 Bytes (0.01%)

@NiranjanaBinoy NiranjanaBinoy mentioned this pull request Oct 21, 2024
Merged
7 tasks
@hjetpoluru hjetpoluru requested review from hjetpoluru and removed request for legobeat November 1, 2024 14:36
hjetpoluru
hjetpoluru approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DDDDDanica DDDDDanica added this pull request to the merge queue Nov 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2024
@DDDDDanica DDDDDanica added this pull request to the merge queue Nov 1, 2024
@DDDDDanica DDDDDanica removed this pull request from the merge queue due to a manual request Nov 1, 2024
@hjetpoluru hjetpoluru added this pull request to the merge queue Nov 1, 2024
Merged via the queue into develop with commit 8c4af60 Nov 1, 2024
81 checks passed
@hjetpoluru hjetpoluru deleted the exportAsFile-error-handling branch November 1, 2024 18:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
@metamaskbot metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@legobeat legobeat legobeat requested changes

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@hjetpoluru hjetpoluru hjetpoluru approved these changes

Assignees

@NiranjanaBinoy NiranjanaBinoy

Labels
external-contributor release-12.8.0 Issue or pull request that will be included in release 12.8.0 team-extension-platform Extension Platform team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NiranjanaBinoy @metamaskbot @DDDDDanica @legobeat @hjetpoluru