fix: missing deadline in swaps stx status screen (#25779)

[martahj]

Description

This PR fixes an issue where the STX status screen for a swap was showing a 0:00 for the timer. It is a cherry-pick of this PR.

Related issues

Related to: #25063

Manual testing steps

1. Make sure Smart Transactions is on (Settings > Advanced)
2. Do a Swap
3. Observe that timer is not 0:00 and is a reasonable number

Screenshots/Recordings

Before

before.mov

After

Screen.Recording.2024-08-20.at.9.39.38.AM.mov

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.64%. Comparing base (a5a7f0e) to head (d7e95af).
Report is 1 commits behind head on Version-v12.1.0.

Files	Patch %	Lines
app/scripts/controllers/swaps.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##           Version-v12.1.0   #26544      +/-   ##
===================================================
- Coverage            69.64%   69.64%   -0.00%     
===================================================
  Files                 1363     1363              
  Lines                48452    48454       +2     
  Branches             13363    13365       +2     
===================================================
  Hits                 33743    33743              
- Misses               14709    14711       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Builds ready [d7e95af]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (450 ± 357 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	76	369	130	60	29
		domContentLoaded	13	85	40	21	10
		load	48	2284	450	743	357
		domInteractive	13	85	40	21	10