-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix:[cherry-pick][V12.1.0] Permit ellipsis fixes (3/4) - add ellipsis for permit fiat values (#26001) #26515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR goal is to add ellipsis to the fiat value if it's more than 15 character in permit simulations. [](https://codespaces.new/MetaMask/metamask-extension/pull/26001?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#2842 ## **Manual testing steps** 1. Go to cowswap 2. Swap a token with gas-free approve for another token 3. Notice the permit signature screen ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <img width="472" alt="Screenshot 2024-07-22 at 14 40 57" src="https://github.com/user-attachments/assets/c5879989-7719-4e4b-902f-1f57144d8889"> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
The fiat logic may have an issue. Decimals are not applied to the fiat value and USDC balance is different from fiat conversion. This is the same in the relevant ticket but with TetherUSD #26001 ![]() |
Builds ready [74e2912]
Page Load Metrics (216 ± 242 ms)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.1.0 #26515 +/- ##
===================================================
+ Coverage 69.64% 69.65% +0.01%
===================================================
Files 1363 1363
Lines 48444 48468 +24
Branches 13357 13367 +10
===================================================
+ Hits 33735 33758 +23
- Misses 14709 14710 +1 ☔ View full report in Codecov by Sentry. |
Description
Cherry-pick fix: add ellipsis for permit fiat values (#26001) into v12.1.0
no line changes
This PR goal is to add ellipsis to the fiat value if it's more than 15 character in permit simulations.
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2842
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Standards.
Pre-merge reviewer checklist
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist