fix: fallback conversion rate for token market data #4615

[bergeron]

Description

Patches MetaMask/core#4615

When the price API does not support the native currency (e.g. MATIC), prices are fetched in ETH and an additional conversion hop is performed to the native currency. But this hop was only being performed on the current price, and was missing on the extended market data like marketCap, allTimeHigh, etc.

Related issues

Manual testing steps

1. Open the token details page for a polygon token
2. Verify market cap, all time low, all time high are correct

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	0	123 kB	metamaskbot
npm/[email protected]	None	0	37.6 kB	dirtyhairy
npm/[email protected]	None	0	75.6 kB	tdegrunt

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

[bergeron]

I don't have a PR to develop for this, since I plan to fix that with an actual package release. But patching for v12.1.0 and probably subsequent minor releases.

[gambinish]

Do I need to bump this on mobile as well? MetaMask/metamask-mobile#10562

[bergeron]

We will bump this on mobile too. Mobile won't consume this data until the PR you linked, so no hotfix just a regular fix.