Skip to content

fix: (cherry-pick Version v11.16.2) duplicate fee display for l2 networks #24871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented May 29, 2024

Description

Cherry-pick 9c83db2 (#24264) into v11.16.2

Open in GitHub Codespaces

Related issues

Fixes: #23291

Manual testing steps

  1. Switch to optimism
  2. Submit legacy transaction in test dapp
  3. Check transaction screen

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested review from a team as code owners May 29, 2024 15:08
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand changed the base branch from develop to Version-v11.16.2 May 29, 2024 15:08
@digiwand digiwand requested a review from a team as a code owner May 29, 2024 15:08
@digiwand digiwand merged commit 1c4c4d0 into Version-v11.16.2 May 29, 2024
62 checks passed
@digiwand digiwand deleted the cherry-pick-l2_layer_display_fix branch May 29, 2024 17:24
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Gas - Duplicated fee section for Legacy transactions in L2
3 participants