Skip to content

feat: Add sepolia and update ppom #23298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2024
Merged

feat: Add sepolia and update ppom #23298

merged 2 commits into from
Mar 5, 2024

Conversation

segun
Copy link
Contributor

@segun segun commented Mar 4, 2024

Description

After last ppom version has been released v1.4.2, we can now use Blockaid in Sepolia. We should add the necessary changes to support it in Extension.

Extra note: there's an upcoming change in geth, which might affect eth_creatAccessList so we need to test this in Sepolia before this is implemented in Mainnet

Open in GitHub Codespaces

Related issues

Fixes: #23272

Manual testing steps

  1. Build MM and launch
  2. Change change to sepolia
  3. Enable Blockaid
  4. Do a PPOM transaction on testdapp
  5. Notice Blockaid validation is not done
  6. Checkout this branch
  7. Repeat step 1-4
  8. Notice Blockaid validation is now down and errors shown

Screenshots/Recordings

Before

sepolia_before.mov

After

after_sepolia.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@segun segun added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 4, 2024
@segun segun self-assigned this Mar 4, 2024
@segun segun requested a review from a team as a code owner March 4, 2024 16:14
Copy link
Contributor

github-actions bot commented Mar 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [e51b433]
Page Load Metrics (1022 ± 407 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint691881162814
domContentLoaded135929157
load5619571022848407
domInteractive135929157
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.59%. Comparing base (5915234) to head (600f417).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23298   +/-   ##
========================================
  Coverage    68.59%   68.59%           
========================================
  Files         1101     1101           
  Lines        43181    43181           
  Branches     11555    11555           
========================================
+ Hits         29619    29620    +1     
+ Misses       13562    13561    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are to add Sepolia and rearrange in Alphabetical order

@jpuri jpuri merged commit 4c6bba1 into develop Mar 5, 2024
@jpuri jpuri deleted the olu/ppom-sepolia branch March 5, 2024 05:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 5, 2024
@metamaskbot metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Mar 5, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [600f417]
Page Load Metrics (1172 ± 426 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint712561315024
domContentLoaded11190323818
load7022651172886426
domInteractive11190323818
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@seaona
Copy link
Contributor

seaona commented Mar 5, 2024

this looks good @segun thank you 🙏

sepolia-support.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.13.0 Issue or pull request that will be included in release 11.13.0 team-confirmations-secure-ux-PR PRs from the confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

PPOM - Support Blockaid validations on Sepolia network
5 participants