Skip to content

[Bug]: Retry (Cancel/Speed up) Tx popover is missing padding for operation buttons #31903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
digiwand opened this issue Apr 11, 2025 · 0 comments · Fixed by #31904
Closed

[Bug]: Retry (Cancel/Speed up) Tx popover is missing padding for operation buttons #31903

digiwand opened this issue Apr 11, 2025 · 0 comments · Fixed by #31904
Assignees
@digiwand
Labels
release-12.18.0 Issue or pull request that will be included in release 12.18.0 team-confirmations Push issues to confirmations team team-extension-platform Extension Platform team

Comments

@digiwand
Copy link
Contributor

Describe the bug

This was fixed in #29338

Then reverted in https://github.com/MetaMask/metamask-extension/pull/31137/files#diff-503fa60e87628a2c02738c80d14b3fe666a3bc8574eed53af6a41a97f8cf9e62L67

We are adding this back in to fix the padding

Expected behavior

No response

Screenshots/Recordings

Image

Steps to reproduce

  1. Create failed transaction
  2. Go to MM
  3. Go to Activity
  4. Click Failed transaction
  5. Observe buttons

Error messages or log output



Detection stage


In production (default)


Version


12.15.2


Build type


None


Browser


Chrome


Operating system


MacOS


Hardware wallet


No response


Additional context


No response


Severity


No response

      		
    

      
  





        



            
            

              
            

        

      


      
    








      

    



      

  
            

    

      
    

    


      

          @digiwand
digiwand




          added
  the 

  type-bug

  Something isn't working
 label


      Apr 11, 2025

    

  



    


    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be fixed
  in Bugs by severity


      Apr 11, 2025

    

  



    

    

      
    

    


      

          @github-project-automation
github-project-automation
bot



          moved this to To be triaged
  in Bugs by team


      Apr 11, 2025

    

  



    

    

      
    

    


      

          @digiwand
digiwand




              self-assigned this


      Apr 11, 2025

    

  



    

    

      
    

    


      

          @metamaskbot
metamaskbot




            added
      

  needs-triage

  Issue needs to be triaged

      

  regression-prod-12.15.2

  Regression bug that was found in production in release 12.15.2

  labels


      Apr 11, 2025

    

  



    

    

      
    

    


      

          @digiwand
digiwand




            added
      

  team-confirmations

  Push issues to confirmations team

      

  team-transactions

  Transactions team

      

  team-wallet-ux


    and removed
      

  type-bug

  Something isn't working

      

  needs-triage

  Issue needs to be triaged

      

  regression-prod-12.15.2

  Regression bug that was found in production in release 12.15.2

  labels


      Apr 11, 2025

    

  



  

  

    
  


  

      

    @digiwand
digiwand



    mentioned this issue
    
      Apr 11, 2025
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    7 tasks
  





  




    

    

      
    

    


      

          @digiwand
digiwand




            added
      

  team-extension-platform

  Extension Platform team

    and removed
      

  team-wallet-ux


      

  team-transactions

  Transactions team

  labels


      Apr 11, 2025

    

  



  


  
    
  
  

    
  github-merge-queue bot

      pushed a commit
      that referenced
      this issue

    
      Apr 12, 2025
    
    

      


  

    

      


  

      
        @digiwand
  





      

        
          fix: missing padding in retry popover (#31904)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          0a94a44
        
      

    

  

    

      
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Adds missing padding in Retry (Cancel/Speed up) popover

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31904?quickstart=1)

## **Related issues**

Fixes:  #31903

## **Manual testing steps**

1. Create failed transaction
2. Go to MM
3. Go to Activity
4. Click Failed transaction
5. Observe buttons

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

![CleanShot 2025-04-11 at 09 40
59](https://github.com/user-attachments/assets/8eed32a8-65bb-4b6d-b078-a7e9f7c091ed)

### **After**

![CleanShot 2025-04-11 at 09 40
46](https://github.com/user-attachments/assets/86e5d239-e8bd-4031-b23c-4b1d13a62aeb)

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

    




    

  




    

    


    

    

      
    

    


      

          @metamaskbot
metamaskbot




          added
  the 

  release-12.18.0

  Issue or pull request that will be included in release 12.18.0
 label


      Apr 12, 2025

    

  



    











  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @digiwand
  
    digiwand
    

      








      


  


  

    Labels
  



    

      

    release-12.18.0

  Issue or pull request that will be included in release 12.18.0
  

    team-confirmations

  Push issues to confirmations team
  

    team-extension-platform

  Extension Platform team








      

  

    

        

    Projects
  


        




        
  

    

      
          
        Bugs by severity
        
    

    

      

          

  

    
      Archived in project



      

    

    

  







  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  




            
  
Successfully merging a pull request may close this issue.





    


  
          
      fix: missing padding in retry popover

    
      MetaMask/metamask-extension
    





      
    

  




      

    

  
      

  

    

      2 participants
    

    

        
          @digiwand 
        
          @metamaskbot