chore: apply lint rules to *.spec.ts files in our e2e
#31852
Labels
release-12.18.0
Issue or pull request that will be included in release 12.18.0
team-extension-platform
Extension Platform team
team-qa
QA team
Comments
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Apr 11, 2025
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** In this PR, we enable lint to the spec files ending with `*.spec.ts` extension. There are no functional changes, so skipping quality the e2e quality gate. Future Work: [apply lint to the other test files (like page objects)](#31853). This will be done in a separate PR, as it will again break lots of files, so it will become a very big PR [](https://codespaces.new/MetaMask/metamask-extension/pull/31834?quickstart=1) ## **Related issues** Fixes: #31852 ## **Manual testing steps** No functional changes 1. Check ci / github actions ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: chloeYue <[email protected]>
](https://codespaces.new/MetaMask/metamask-extension/pull/31834?quickstart=1){kind=link}
metamaskbot
added
the
release-12.18.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
apply lint rules to
*.spec.tsfiles in our e2eScenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response
The text was updated successfully, but these errors were encountered: