Skip to content

Scaffold Enable Swaps Flow #31451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
9 tasks
matallui opened this issue Mar 31, 2025 · 0 comments · Fixed by #31582
Closed
9 tasks

Scaffold Enable Swaps Flow #31451

matallui opened this issue Mar 31, 2025 · 0 comments · Fixed by #31582
Assignees
@kevinbluer
Labels
release-12.18.0 Issue or pull request that will be included in release 12.18.0 team-vault MetaMask Vault Team

Comments

@matallui
Copy link
Contributor

What is this about?

Scaffold the flow for enabling remote mode swaps.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@matallui matallui added the team-vault MetaMask Vault Team label Mar 31, 2025
@kevinbluer kevinbluer mentioned this issue Apr 3, 2025
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Apr 10, 2025
@kevinbluer
feat: Remote Mode - Enabling Swaps / Daily Allowance screens and comp…
58b568a 
…onents (#31582)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

> Note the Remote Mode feature is still work-in-progress and currently
behind the `vaultRemoteMode` feature flag so shouldn't accessible by
users.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

- This PR adds a the initial screens (and associated components) for
enabling swaps and daily allowances as part of the upcoming remote mode
feature
- As highlighted earlier, this feature is still in progress and the
screens and associated components are to provide the surface area for
the actual feature + functional implementation. A number of elements are
missing and will be added in separate PR's, including (although not
limited to):
  - i18n
  - Refactors to the screens / components themselves

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31582?quickstart=1)

## **Related issues**

Fixes:
[31451](#31451),
[31452](https://github.com/orgs/MetaMask/projects/167?pane=issue&itemId=104376654&issue=MetaMask%7Cmetamask-extension%7C31452)

## **Manual testing steps**

1. Create the build (`yarn webpack`)
2. Go to `home.html#remote` and walk through the screens using the
recording below for reference
- Note to override the `vaultRemoteMode` feature flag (which will
implicitly default to disabled), the configuration steps are available
[here](https://github.com/MetaMask/contributor-docs/blob/main/docs/remote-feature-flags.md#a-local-build).
Example`.manifest-overrides.json`:

```json
{
  "_flags": {
    "remoteFeatureFlags": {
      "vaultRemoteMode": true
    }
  }
}
```

4. The components and screens can also be viewed in Storybook (`yarn
storybook`) under the Vault namespace

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

NA

### **After**



https://github.com/user-attachments/assets/1849de42-cdcd-419b-835b-482034c272ad



## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-12.18.0 Issue or pull request that will be included in release 12.18.0 label Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinbluer kevinbluer

Labels
release-12.18.0 Issue or pull request that will be included in release 12.18.0 team-vault MetaMask Vault Team
Projects
None yet
Milestone
No milestone
3 participants
@kevinbluer @matallui @metamaskbot