Skip to content

[Bug]: Extension crash when clicking on Bridge button #30662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davibroc opened this issue Mar 1, 2025 · 0 comments · Fixed by #30671
Closed

[Bug]: Extension crash when clicking on Bridge button #30662

davibroc opened this issue Mar 1, 2025 · 0 comments · Fixed by #30671
Labels
needs-triage Issue needs to be triaged regression-main Regression bug that was found on main branch, but not yet present in production release-12.15.0 Issue or pull request that will be included in release 12.15.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-accounts team-bridge DEPRECATED: Use team-swaps-and-bridge type-bug Something isn't working

Comments

@davibroc
Copy link
Contributor

davibroc commented Mar 1, 2025

Describe the bug

After building the extension locally with yarn & yarn dist and doing a fresh install and click on bridge the extension will crash with this error. See video below

Image

Expected behavior

I am able to perform a Bridge

Screenshots/Recordings

Screen.Recording.2025-02-28.at.5.40.41.PM.mov

Steps to reproduce

  1. Build the latest main with yarn && yarn dist
  2. Do a fresh install and create new wallet
  3. Click on Bridge and the Extension will crash

Error messages or log output

Detection stage

On main branch

Version

12.10.1

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@davibroc davibroc added the type-bug Something isn't working label Mar 1, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Mar 1, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Mar 1, 2025
@davibroc davibroc added team-accounts team-bridge DEPRECATED: Use team-swaps-and-bridge Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. labels Mar 1, 2025
@metamaskbot metamaskbot added regression-main Regression bug that was found on main branch, but not yet present in production needs-triage Issue needs to be triaged labels Mar 1, 2025
GustavoRSSilva added a commit that referenced this issue Mar 3, 2025
## **Description**

When the users does not have a non Evm account, the bridge cannot
calculated the users balance.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30671?quickstart=1)

## **Related issues**

Fixes: #30662

## **Manual testing steps**

1. Build the App
2. Go to the brige page

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**



### **After**

<img width="679" alt="Screenshot 2025-03-03 at 10 00 26"
src="https://github.com/user-attachments/assets/144d091f-f73e-4270-9cc1-85275fdd9574"
/>


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
github-merge-queue bot pushed a commit that referenced this issue Mar 3, 2025
## **Description**

When the users does not have a non Evm account, the bridge cannot
calculated the users balance.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30671?quickstart=1)

## **Related issues**

Fixes: #30662

## **Manual testing steps**

1. Build the App
2. Go to the brige page

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**



### **After**

<img width="679" alt="Screenshot 2025-03-03 at 10 00 26"
src="https://github.com/user-attachments/assets/144d091f-f73e-4270-9cc1-85275fdd9574"
/>


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Mar 3, 2025
@github-project-automation github-project-automation bot moved this from To be triaged to Ready to be fixed in Bugs by team Mar 3, 2025
@metamaskbot metamaskbot added the release-12.15.0 Issue or pull request that will be included in release 12.15.0 label Mar 3, 2025
GustavoRSSilva added a commit that referenced this issue Mar 3, 2025
## **Description**

When the users does not have a non Evm account, the bridge cannot
calculated the users balance.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30671?quickstart=1)

## **Related issues**

Fixes: #30662

## **Manual testing steps**

1. Build the App
2. Go to the brige page

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**



### **After**

<img width="679" alt="Screenshot 2025-03-03 at 10 00 26"
src="https://github.com/user-attachments/assets/144d091f-f73e-4270-9cc1-85275fdd9574"
/>


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
GustavoRSSilva added a commit that referenced this issue Mar 3, 2025
## **Description**

When the users does not have a non Evm account, the bridge cannot
calculated the users balance.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30671?quickstart=1)

## **Related issues**

Fixes: #30662

## **Manual testing steps**

1. Build the App
2. Go to the brige page

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**



### **After**

<img width="679" alt="Screenshot 2025-03-03 at 10 00 26"
src="https://github.com/user-attachments/assets/144d091f-f73e-4270-9cc1-85275fdd9574"
/>


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
GustavoRSSilva added a commit that referenced this issue Mar 4, 2025
## **Description**

When the users does not have a non Evm account, the bridge cannot
calculated the users balance.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30671?quickstart=1)

## **Related issues**

Fixes: #30662

## **Manual testing steps**

1. Build the App
2. Go to the brige page

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**



### **After**

<img width="679" alt="Screenshot 2025-03-03 at 10 00 26"
src="https://github.com/user-attachments/assets/144d091f-f73e-4270-9cc1-85275fdd9574"
/>


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
GustavoRSSilva added a commit that referenced this issue Mar 4, 2025
## **Description**

When the users does not have a non Evm account, the bridge cannot
calculated the users balance.

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30671?quickstart=1)

## **Related issues**

Fixes: #30662

## **Manual testing steps**

1. Build the App
2. Go to the brige page

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**



### **After**

<img width="679" alt="Screenshot 2025-03-03 at 10 00 26"
src="https://github.com/user-attachments/assets/144d091f-f73e-4270-9cc1-85275fdd9574"
/>


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30698?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Issue needs to be triaged regression-main Regression bug that was found on main branch, but not yet present in production release-12.15.0 Issue or pull request that will be included in release 12.15.0 Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-accounts team-bridge DEPRECATED: Use team-swaps-and-bridge type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants