Skip to content

Fix "Account syncing - User already has balances on multple accounts from inside MetaMask when a user has balances on more accounts than previously synced, it should be handled gracefully" #30057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
9 tasks
seaona opened this issue Feb 3, 2025 · 0 comments · Fixed by #30044
Closed
9 tasks

Fix "Account syncing - User already has balances on multple accounts from inside MetaMask when a user has balances on more accounts than previously synced, it should be handled gracefully" #30057

seaona opened this issue Feb 3, 2025 · 0 comments · Fixed by #30044
Assignees
@seaona
Labels
area-qa Relating to QA work (Quality Assurance) flaky tests release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-qa QA team

Comments

@seaona
Copy link
Contributor

seaona commented Feb 3, 2025

What is this about?

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/121879/workflows/9dc68e75-c842-4b3d-83c5-eaacbca0c5aa/jobs/4509367/tests#failed-test-0

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response
@seaona seaona added area-qa Relating to QA work (Quality Assurance) flaky tests team-qa QA team labels Feb 3, 2025
@seaona seaona self-assigned this Feb 3, 2025
@seaona seaona mentioned this issue Feb 3, 2025
Merged
7 tasks
@seaona seaona closed this as completed Feb 3, 2025
github-merge-queue bot pushed a commit that referenced this issue Feb 3, 2025
@seaona
fix: flaky test timeout `Account syncing - User already has balances …
bf07901 
…on multple accounts from inside MetaMask when a user has balances on more accounts than previously synced, it should be handled gracefully` (#30044)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Test times out from time to time, as it's very long.


https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/121879/workflows/9dc68e75-c842-4b3d-83c5-eaacbca0c5aa/jobs/4509367/tests#failed-test-0

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30044?quickstart=1)

## **Related issues**

Fixes: #30057

## **Manual testing steps**

1. Run locañlly
2. Check ci

## **Screenshots/Recordings**

![Screenshot from 2025-02-01
11-35-48](https://github.com/user-attachments/assets/95829ce4-043d-469d-aab8-1619217a4a98)


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 3, 2025
seaona added a commit that referenced this issue Feb 6, 2025
@seaona
fix: flaky test timeout `Account syncing - User already has balances …
09fe356 
…on multple accounts from inside MetaMask when a user has balances on more accounts than previously synced, it should be handled gracefully` (#30044)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Test times out from time to time, as it's very long.


https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/121879/workflows/9dc68e75-c842-4b3d-83c5-eaacbca0c5aa/jobs/4509367/tests#failed-test-0

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/30044?quickstart=1)

## **Related issues**

Fixes: #30057

## **Manual testing steps**

1. Run locañlly
2. Check ci

## **Screenshots/Recordings**

![Screenshot from 2025-02-01
11-35-48](https://github.com/user-attachments/assets/95829ce4-043d-469d-aab8-1619217a4a98)


## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seaona seaona

Labels
area-qa Relating to QA work (Quality Assurance) flaky tests release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-qa QA team
Projects
None yet
Milestone
No milestone
2 participants
@metamaskbot @seaona