[Bug]: Missing "Unlimited" as value for the DAI permit

[bschorchit]

Describe the bug

For DAI permit, we're currently displaying no value for DAI permits.

Expected behavior

For DAI permit, we should display Unlimited as the value within estimated changes.

Screenshots/Recordings

Steps to reproduce

Payload:

{
  "types": {
    "EIP712Domain": [
      {
        "name": "name",
        "type": "string"
      },
      {
        "name": "version",
        "type": "string"
      },
      {
        "name": "chainId",
        "type": "uint256"
      },
      {
        "name": "verifyingContract",
        "type": "address"
      }
    ],
    "Permit": [
      {
        "name": "holder",
        "type": "address"
      },
      {
        "name": "spender",
        "type": "address"
      },
      {
        "name": "nonce",
        "type": "uint256"
      },
      {
        "name": "expiry",
        "type": "uint256"
      },
      {
        "name": "allowed",
        "type": "bool"
      }
    ]
  },
  "domain": {
    "name": "Dai Stablecoin",
    "version": "1",
    "verifyingContract": "0x6B175474E89094C44Da98b954EedeAC495271d0F",
    "chainId": "0x1"
  },
  "primaryType": "Permit",
  "message": {
    "holder": "0xD2C44F28eC4C7eF686f587FADdb204da3aEFa827",
    "spender": "0x68b3465833fb72A70ecDF485E0e4C7bD8665Fc45",
    "allowed": true,
    "nonce": 0,
    "expiry": 1660916504
  }
}

API response:

{
	"stateChanges": [
		{
			"assetType": "ERC20",
			"changeType": "APPROVE",
			"address": "0x68b3465833fb72A70ecDF485E0e4C7bD8665Fc45",
			"amount": "115792089237316195423570985008687907853269984665640564039457584007913129639935",
			"contractAddress": "0x6B175474E89094C44Da98b954EedeAC495271d0F"
		}
	]
}

Error messages or log output

No response

Detection stage

During release testing

Version

12.9.0

Build type

None

Browser

Brave

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

[digiwand]

created a ticket to add this support here some time ago. Fixing this bug should resolve this ticket:
#27269

unrelated to the ticket, but related to 2612 backwards compatibility support, we will also need to support:
#27357

[jpuri]

Hey @bschorchit : the simulation displayed above are not returned by decoding api but they are implemented by us in UI.

Decoding api for request above is returning NotSupported:

Reason could be that request body does not comply to 712 format.

[imblue-dabadee]

Ah, the correct payload would be:

{
	"method": "eth_signTypedData_v4",
	"params": [
		"0xD2C44F28eC4C7eF686f587FADdb204da3aEFa827",
		{
			"types": {
				"EIP712Domain": [
					{
						"name": "name",
						"type": "string"
					},
					{
						"name": "version",
						"type": "string"
					},
					{
						"name": "chainId",
						"type": "uint256"
					},
					{
						"name": "verifyingContract",
						"type": "address"
					}
				],
				"Permit": [
					{
						"name": "holder",
						"type": "address"
					},
					{
						"name": "spender",
						"type": "address"
					},
					{
						"name": "nonce",
						"type": "uint256"
					},
					{
						"name": "expiry",
						"type": "uint256"
					},
					{
						"name": "allowed",
						"type": "bool"
					}
				]
			},
			"domain": {
				"name": "Dai Stablecoin",
				"version": "1",
				"verifyingContract": "0x6B175474E89094C44Da98b954EedeAC495271d0F",
				"chainId": "0x1"
			},
			"primaryType": "Permit",
			"message": {
				"holder": "0xD2C44F28eC4C7eF686f587FADdb204da3aEFa827",
				"spender": "0x68b3465833fb72A70ecDF485E0e4C7bD8665Fc45",
				"allowed": true,
				"nonce": 0,
				"expiry": 2060916504
			}
		}
	]
}

I should've clarified that I was simply pasting the params field.

[jpuri]

Hey @imblue-dabadee , @bschorchit : I used the sample request above and it is giving me this error:

[jpuri]

Additionally displaying Unlimited for very large values will be addressed by this issue: https://github.com/MetaMask/MetaMask-planning/issues/3763

[jpuri]

For DAI we need to fix our default implementation to display UNLIMITED is user is granted access. Take into account value of allowed field for displaying this. : https://eips.ethereum.org/EIPS/eip-2612. True for allowed is unlimited approval and false is revoke.

Note: our default implementation for permit is displayed when decoding api result is not available.