[Bug]: Misalignment in send, speed up, cancel and swaps screens #28722
Assignees
Labels
regression-main
Regression bug that was found on main branch, but not yet present in production
release-12.9.0
Issue or pull request that will be included in release 12.9.0
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-bridge
DEPRECATED: Use team-swaps-and-bridge
type-bug
Something isn't working
Comments
Unik0rnMaggie
added
regression-main
hjetpoluru
added
the
Sev2-normal
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 26, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Problem: A scss change for preventing modal scrolling in the bridge experience was added and got unintentionally applied to all modals. Solution: Nest the styling within the `quotes-modal` className <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/28739?quickstart=1) ## **Related issues** Fixes: #28722 ## **Manual testing steps** 1. Visually inspect Swap token picker 2. Visually inspect tx "Speed up" and "Cancel" layout ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** See bug report screenshots <!-- [screenshots/recordings] --> ### **After**  <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
metamaskbot
added
the
release-12.9.0
|
Looks great! speedUpCancel.movswap.mov
|
](https://codespaces.new/MetaMask/metamask-extension/pull/28739?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The Send screen and Swap to, swap from screens look different:
Expected behavior
Same alignment as before:
Screenshots/Recordings
Steps to reproduce
developbranchError messages or log output
No response
Detection stage
On the development branch
Version
12.7.0
Build type
Other (please specify exactly where you obtained this build in "Additional Context" section)
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: