[Bug]: when interacting with dApp permissions, the correct number of connected accounts is only displayed when a single account is selected #28312
Labels
regression-RC-12.7.0
Sev3-low
Low severity; minimal to no impact upon users
team-wallet-ux
type-bug
Something isn't working
Comments
sleepytanya
added
type-bug
sleepytanya
added
team-wallet-ux
and removed
team-confirmations
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 26, 2024
This PR is to: 1. Show correct account names when dapp tries to connect with MM and account is imported 2. Show correct length of accounts when more than one account is connected ## **Related issues** Fixes: [3685-planning](MetaMask/MetaMask-planning#3685 ) #28312 ## **Manual testing steps** 1. Import an account in MM 2. Initiate connection request from Dapp, check correct name of account is shown on connections page 3. After connecting, select more than account, check length of accounts shown is correct ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/user-attachments/assets/bb7281c6-0f92-4160-a09b-9a69fe69d671 ### **After** https://github.com/user-attachments/assets/96d45514-74b1-451c-a136-889821b31e22 ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
Fixed by Nidhi's PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The
Permissionsscreen accurately displays the number of enabled networks and connected accounts. However, when interacting with dApp permissions, the correct number of connected accounts is only displayed when a single account is selected. Adding another account causes the display to reflect the total number of accounts in the walletExpected behavior
Screenshots/Recordings
permissions.mov
Steps to reproduce
Error messages or log output
No response
Detection stage
During release testing
Version
12.7.0
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: