Skip to content

Commit 9384f43

Browse files
runway-github[bot]vinnyhowardDDDDDanica
authored
chore(runway): cherry-pick fix: remove unnecessary method call cp-12.18.0 (#32449)
- fix: remove unnecessary method call cp-12.18.0 (#32392) ## **Description** Issue: This method call was added to prepare for this [PR](#31223) but hasn't been merged yet and the underlying API has issues so we don't need it at all until its merged and the endpoint is fixed. Solution: Remove `getNetworksWithTransactionActivityByAccounts` for now until the PR is merged. This has no affect on the component/functionality [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32392?quickstart=1) ## **Related issues** Related to: [4469](https://github.com/MetaMask/MetaMask-planning/issues/4469) ## **Manual testing steps** 1. No QA needed 2. 3. ## **Screenshots/Recordings** NA ### **Before** NA ### **After** NA ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [1161ad6](1161ad6) Co-authored-by: Vince Howard <[email protected]> Co-authored-by: Danica Shen <[email protected]>
1 parent 661c136 commit 9384f43

File tree

1 file changed

+1
-19
lines changed

1 file changed

+1
-19
lines changed

ui/components/multichain/account-list-menu/account-list-menu.tsx

+1-19
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,7 @@ import {
7676
getHDEntropyIndex,
7777
getAllChainsToPoll,
7878
} from '../../../selectors';
79-
import {
80-
detectNfts,
81-
setSelectedAccount,
82-
getNetworksWithTransactionActivityByAccounts,
83-
} from '../../../store/actions';
79+
import { detectNfts, setSelectedAccount } from '../../../store/actions';
8480
import {
8581
MetaMetricsEventAccountType,
8682
MetaMetricsEventCategory,
@@ -516,20 +512,6 @@ export const AccountListMenu = ({
516512
};
517513
///: END:ONLY_INCLUDE_IF(multichain)
518514

519-
const fetchAccountsWithActivity = useCallback(async () => {
520-
try {
521-
await dispatch(getNetworksWithTransactionActivityByAccounts());
522-
} catch (error) {
523-
console.error('Failed to fetch accounts with activity:', error);
524-
}
525-
}, [dispatch]);
526-
527-
useEffect(() => {
528-
if (filteredAccounts.length > 0) {
529-
fetchAccountsWithActivity();
530-
}
531-
}, [fetchAccountsWithActivity, filteredAccounts]);
532-
533515
return (
534516
<Modal isOpen onClose={onClose}>
535517
<ModalOverlay />

0 commit comments

Comments
 (0)