temp+fix: (cp-12.17.1) patch notification services controller (#32391)

## **Description**

Wow, huge oopsy on my side. Urgh, a little annoyed that I didn't spot
this earlier.

After doing some thorough debugging, I found an infinite state update
loop from the NotificationServicesController.
I didn't find the full context but this controller:

- Listens to `KeyringController:stateChange` events
- When receiving an event we perform a `KeyringController:withKeyring`
action.

Somewhere above (or potentially another controller firing events or
actions?) will then fire another `KeyringController:stateChange` and the
loop repeats. This prevents other state updates and redux updates.

Controller fix: MetaMask/core#5731
However this patch can be an interim for existing releases or until the
CORE package is released.

<details><summary>Screenshot of background logs</summary>

![Screenshot 2025-04-29 at 22 43
03](https://github.com/user-attachments/assets/a1f07672-d471-4e60-8124-e6644df0b5f4)

</details> 

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32391?quickstart=1)

## **Related issues**

Fixes: Potentially fixes
#32416
#31422

## **Manual testing steps**

1. Turn on notifications
2. Try dismissing the carousel banners
3. Try switching networks
4. Try the send flow where you send sepolia

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: runway-github[bot]

.circleci/config.yml

@@ -25,9 +25,29 @@ executors:
     resource_class: medium+
     environment:
       NODE_OPTIONS: --max_old_space_size=4096
+  playwright:
+    docker:
+      - image: mcr.microsoft.com/playwright:v1.44.1-focal
+    resource_class: medium
 
 orbs:
   gh: circleci/[email protected]
+  codecov: codecov/[email protected]
+  slack: circleci/[email protected]
+
+rc_branch_only: &rc_branch_only
+  filters:
+    branches:
+      only:
+        - /^Version-v(\d+)[.](\d+)[.](\d+)/
+
+main_master_rc_only: &main_master_rc_only
+  filters:
+    branches:
+      only:
+        - main
+        - master
+        - /^Version-v(\d+)[.](\d+)[.](\d+)/
 
 aliases:
   # Shallow Git Clone
@@ -101,6 +121,9 @@ workflows:
       - prep-build-test-mv2:
           requires:
             - prep-deps
+      - prep-build-test-webpack:
+          requires:
+            - prep-deps
       - prep-build-test-flask:
           requires:
             - prep-deps
@@ -110,6 +133,24 @@ workflows:
       - prep-build-ts-migration-dashboard:
           requires:
             - prep-deps
+      - test-e2e-chrome-webpack:
+          <<: *main_master_rc_only
+          requires:
+            - prep-build-test-webpack
+            - get-changed-files-with-git-diff
+      - test-e2e-chrome:
+          requires:
+            - prep-build-test
+            - get-changed-files-with-git-diff
+      - test-e2e-firefox:
+          <<: *main_master_rc_only
+          requires:
+            - prep-build-test-mv2
+            - get-changed-files-with-git-diff
+      - test-e2e-chrome-rpc:
+          requires:
+            - prep-build-test
+            - get-changed-files-with-git-diff
       - test-api-specs:
           requires:
             - prep-build-test
@@ -118,6 +159,29 @@ workflows:
           requires:
             - prep-build-test-flask
             - get-changed-files-with-git-diff
+      - test-e2e-chrome-multiple-providers:
+          requires:
+            - prep-build-test
+            - get-changed-files-with-git-diff
+      - test-e2e-chrome-flask:
+          requires:
+            - prep-build-test-flask
+            - get-changed-files-with-git-diff
+      - test-e2e-firefox-flask:
+          <<: *main_master_rc_only
+          requires:
+            - prep-build-test-flask-mv2
+      - test-e2e-swap-playwright - OPTIONAL:
+          requires:
+            - prep-build
+      - test-e2e-chrome-vault-decryption:
+          filters:
+            branches:
+              only:
+                - main
+                - /^Version-v(\d+)[.](\d+)[.](\d+)/
+          requires:
+            - prep-build
       - validate-source-maps:
           requires:
             - prep-build
@@ -144,6 +208,13 @@ workflows:
             - validate-source-maps-flask
             - test-mozilla-lint-mv2
             - test-mozilla-lint-flask-mv2
+            - test-e2e-chrome
+            - test-e2e-chrome-multiple-providers
+            - test-e2e-firefox
+            - test-e2e-chrome-flask
+            - test-e2e-firefox-flask
+            - test-e2e-chrome-vault-decryption
+            - test-e2e-chrome-webpack
       - job-publish-prerelease:
           requires:
             - prep-deps
@@ -504,6 +575,26 @@ jobs:
             - dist-test-mv2
             - builds-test-mv2
 
+  prep-build-test-webpack:
+    executor: node-linux-medium
+    steps:
+      - run: *shallow-git-clone-and-enable-vnc
+      - attach_workspace:
+          at: .
+      - run:
+          name: Activate yarn
+          command: corepack enable
+      - run:
+          name: Build extension for testing
+          command: yarn build:test:webpack
+      - run:
+          name: Move test build to 'dist-test-webpack' to avoid conflict with production build
+          command: mv ./dist ./dist-test-webpack
+      - persist_to_workspace:
+          root: .
+          paths:
+            - dist-test-webpack
+
   prep-build-ts-migration-dashboard:
     executor: node-browsers-small
     steps:
@@ -530,6 +621,27 @@ jobs:
           name: Rerun workflows from failed
           command: yarn ci-rerun-from-failed
 
+  test-e2e-chrome-webpack:
+    executor: node-browsers-medium-plus
+    parallelism: 20
+    steps:
+      - run: *shallow-git-clone-and-enable-vnc
+      - run: sudo corepack enable
+      - attach_workspace:
+          at: .
+      - run:
+          name: Move test build to dist
+          command: mv ./dist-test-webpack ./dist
+      - run:
+          name: test:e2e:chrome:webpack
+          command: .circleci/scripts/test-run-e2e.sh yarn test:e2e:chrome:webpack
+          no_output_timeout: 5m
+      - store_artifacts:
+          path: test-artifacts
+          destination: test-artifacts
+      - store_test_results:
+          path: test/test-results/e2e
+
   test-api-specs-multichain:
     executor: node-browsers-medium-plus
     steps:
@@ -592,6 +704,198 @@ jobs:
           path: html-report
           destination: html-report
 
+  test-e2e-chrome:
+    executor: node-browsers-medium-plus
+    parallelism: 20
+    steps:
+      - run: *shallow-git-clone-and-enable-vnc
+      - run: sudo corepack enable
+      - attach_workspace:
+          at: .
+      - run:
+          name: Move test build to dist
+          command: mv ./dist-test ./dist
+      - run:
+          name: Move test zips to builds
+          command: mv ./builds-test ./builds
+      - run:
+          name: test:e2e:chrome
+          command: .circleci/scripts/test-run-e2e.sh yarn test:e2e:chrome
+          no_output_timeout: 5m
+      - store_artifacts:
+          path: test-artifacts
+          destination: test-artifacts
+      - store_test_results:
+          path: test/test-results/e2e
+
+  test-e2e-chrome-rpc:
+    executor: node-browsers-medium
+    parallelism: 1
+    steps:
+      - run: *shallow-git-clone-and-enable-vnc
+      - run: sudo corepack enable
+      - attach_workspace:
+          at: .
+      - run:
+          name: Move test build to dist
+          command: mv ./dist-test ./dist
+      - run:
+          name: Move test zips to builds
+          command: mv ./builds-test ./builds
+      - run:
+          name: test:e2e:chrome:rpc
+          command: .circleci/scripts/test-run-e2e.sh yarn test:e2e:chrome:rpc
+          no_output_timeout: 5m
+      - store_artifacts:
+          path: test-artifacts
+          destination: test-artifacts
+      - store_test_results:
+          path: test/test-results/e2e
+
+  test-e2e-chrome-multiple-providers:
+    executor: node-browsers-small
+    parallelism: 1
+    steps:
+      - run: *shallow-git-clone-and-enable-vnc
+      - run: sudo corepack enable
+      - attach_workspace:
+          at: .
+      - run:
+          name: Move test build to dist
+          command: mv ./dist-test ./dist
+      - run:
+          name: Move test zips to builds
+          command: mv ./builds-test ./builds
+      - run:
+          name: test:e2e:chrome:multi-provider
+          command: .circleci/scripts/test-run-e2e.sh yarn test:e2e:chrome:multi-provider
+          no_output_timeout: 5m
+      - store_artifacts:
+          path: test-artifacts
+          destination: test-artifacts
+      - store_test_results:
+          path: test/test-results/e2e
+
+  test-e2e-chrome-vault-decryption:
+    executor: node-browsers-medium-plus
+    steps:
+      - run: *shallow-git-clone-and-enable-vnc
+      - run: sudo corepack enable
+      - attach_workspace:
+          at: .
+      - run:
+          name: test:e2e:single
+          command: .circleci/scripts/test-run-e2e.sh yarn test:e2e:single test/e2e/vault-decryption-chrome.spec.ts --browser chrome
+          no_output_timeout: 5m
+      - store_artifacts:
+          path: test-artifacts
+          destination: test-artifacts
+      - store_test_results:
+          path: test/test-results/e2e
+
+  test-e2e-firefox-flask:
+    executor: node-browsers-medium-plus
+    parallelism: 10
+    steps:
+      - run: *shallow-git-clone-and-enable-vnc
+      - run: sudo corepack enable
+      - attach_workspace:
+          at: .
+      - run:
+          name: Move test build to dist
+          command: mv ./dist-test-flask-mv2 ./dist
+      - run:
+          name: Move test zips to builds
+          command: mv ./builds-test-flask-mv2 ./builds
+      - run:
+          name: test:e2e:firefox:flask
+          command: .circleci/scripts/test-run-e2e.sh yarn test:e2e:firefox:flask
+          no_output_timeout: 5m
+      - store_artifacts:
+          path: test-artifacts
+          destination: test-artifacts
+      - store_test_results:
+          path: test/test-results/e2e
+
+  test-e2e-chrome-flask:
+    executor: node-browsers-medium-plus
+    parallelism: 8
+    steps:
+      - run: *shallow-git-clone-and-enable-vnc
+      - run: sudo corepack enable
+      - attach_workspace:
+          at: .
+      - run:
+          name: Move test build to dist
+          command: mv ./dist-test-flask ./dist
+      - run:
+          name: Move test zips to builds
+          command: mv ./builds-test-flask ./builds
+      - run:
+          name: test:e2e:chrome:flask
+          command: .circleci/scripts/test-run-e2e.sh yarn test:e2e:chrome:flask
+          no_output_timeout: 5m
+      - store_artifacts:
+          path: test-artifacts
+          destination: test-artifacts
+      - store_test_results:
+          path: test/test-results/e2e
+
+  test-e2e-swap-playwright - OPTIONAL:
+    executor: playwright
+    parallelism: 2
+    steps:
+      - run: *shallow-git-clone-and-enable-vnc
+      - run: corepack enable
+      - attach_workspace:
+          at: .
+      - run:
+          name: Install chromium
+          command: yarn playwright install chromium
+      - run:
+          name: test:e2e:chrome:swap
+          command: |
+            TESTFILES=$(circleci tests glob "test/e2e/playwright/swap/**/*.spec.ts")
+            echo "$TESTFILES"
+            echo "$TESTFILES" | timeout 20m circleci tests run --command="xvfb-run xargs yarn playwright test --project=swap" verbose || true
+            # above line makes it never fail, and these tests are going away soon
+          no_output_timeout: 10m
+      - slack/notify:
+          event: fail
+          mentions: <@davide.brocchetto>
+          template: basic_fail_1
+          channel: C06BEG71R1S
+      - store_artifacts:
+          name: html-report and artifacts
+          path: public/playwright/playwright-reports
+      - store_test_results:
+          name: report for pipeline integration
+          path: public/playwright/playwright-reports/junit/test-results.xml
+
+  test-e2e-firefox:
+    executor: node-browsers-medium-plus
+    parallelism: 24
+    steps:
+      - run: *shallow-git-clone-and-enable-vnc
+      - run: sudo corepack enable
+      - attach_workspace:
+          at: .
+      - run:
+          name: Move test build to dist
+          command: mv ./dist-test-mv2 ./dist
+      - run:
+          name: Move test zips to builds
+          command: mv ./builds-test-mv2 ./builds
+      - run:
+          name: test:e2e:firefox
+          command: .circleci/scripts/test-run-e2e.sh yarn test:e2e:firefox
+          no_output_timeout: 5m
+      - store_artifacts:
+          path: test-artifacts
+          destination: test-artifacts
+      - store_test_results:
+          path: test/test-results/e2e
+
   job-publish-prerelease:
     executor: node-browsers-medium
     steps:

.depcheckrc.yml

@@ -24,7 +24,6 @@ ignores:
   - '@metamask/phishing-warning' # statically hosted as part of some e2e tests
   - '@metamask/test-dapp'
   - '@metamask/test-dapp-multichain'
-  - '@metamask/test-dapp-solana'
   - '@metamask/design-tokens' # Only imported in index.css
   - '@tsconfig/node22' # required dynamically by TS, used in tsconfig.json
   - '@sentry/cli' # invoked as `sentry-cli`
@@ -44,8 +43,6 @@ ignores:
   - 'prettier-eslint' # used by the Prettier ESLint VSCode extension
   - 'tar' # used by foundryup.ts
   - 'minipass' # used by foundryup.ts
-  - 'tweetnacl' # used by solana-wallet-standard
-  - 'bs58' # used by solana-wallet-standard
   # storybook
   - '@storybook/cli'
   - '@storybook/core'
@@ -88,14 +85,6 @@ ignores:
   - '@testing-library/dom'
   - 'mini-css-extract-plugin'
   - 'webpack-cli'
-  # preinstalled snaps
-  - '@metamask/preinstalled-example-snap'
-  - '@metamask/ens-resolver-snap'
-  - '@metamask/message-signing-snap'
-  - '@metamask/account-watcher'
-  - '@metamask/bitcoin-wallet-snap'
-  - '@metamask/solana-wallet-snap'
-  - '@metamask/institutional-wallet-snap'
 
 # files depcheck should not parse
 ignorePatterns: