Skip to content

Commit 9ce7f3f

Browse files
feat: use MetaMask build name for solana cp-12.18.0 (#32356)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> No matter the build, MetaMask Solana always announced itself with the same name. Now we’re using the build name. ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/32356?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#4770 ## **Manual testing steps** 1. Build MetaMask Snap 2. Go this page: https://metamask.github.io/test-dapp-solana/staging/ 3. Click on "Select Wallet" ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <img width="431" alt="Screenshot 2025-04-28 at 19 04 30" src="https://github.com/user-attachments/assets/7685f879-19c6-4b9b-90e8-2a76e8aa426d" /> <img width="508" alt="Screenshot 2025-04-28 at 19 28 16" src="https://github.com/user-attachments/assets/6ee62ab8-f610-4c5f-b26c-1f623d4d6148" /> <img width="426" alt="Screenshot 2025-04-28 at 19 28 21" src="https://github.com/user-attachments/assets/be7daf25-08ef-4ba0-97a2-72a030daa4dd" /> <img width="391" alt="Screenshot 2025-04-28 at 19 29 12" src="https://github.com/user-attachments/assets/90fa8904-99e8-44b0-8ac1-a24585886f5e" /> <!-- [screenshots/recordings] --> ### **After** <img width="442" alt="Screenshot 2025-04-28 at 21 50 24" src="https://github.com/user-attachments/assets/238d185f-52c6-40e3-b05a-2e5407625236" /> <img width="386" alt="Screenshot 2025-04-28 at 21 55 59" src="https://github.com/user-attachments/assets/af46b25b-e778-4fd2-931e-88e3239ffa4e" /> <img width="406" alt="Screenshot 2025-04-28 at 21 56 03" src="https://github.com/user-attachments/assets/62652ddc-4763-44eb-bddc-aa308ca49df5" /> <img width="388" alt="Screenshot 2025-04-28 at 21 56 28" src="https://github.com/user-attachments/assets/3a437db3-06e4-4ca9-8d0c-9f5648f85dff" /> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 6892a5f commit 9ce7f3f

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

app/scripts/inpage.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,9 @@ if (shouldInjectProvider()) {
9090
getMultichainClient({
9191
transport: getDefaultTransport(),
9292
}).then((client) => {
93-
registerSolanaWalletStandard({ client });
93+
registerSolanaWalletStandard({
94+
client,
95+
walletName: process.env.METAMASK_BUILD_NAME,
96+
});
9497
});
9598
}

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@
328328
"@metamask/snaps-sdk": "^6.22.1",
329329
"@metamask/snaps-utils": "^9.2.1",
330330
"@metamask/solana-wallet-snap": "^1.24.0",
331-
"@metamask/solana-wallet-standard": "^0.3.0",
331+
"@metamask/solana-wallet-standard": "^0.4.1",
332332
"@metamask/transaction-controller": "^54.3.0",
333333
"@metamask/user-operation-controller": "^31.0.0",
334334
"@metamask/utils": "^11.1.0",

yarn.lock

+5-5
Original file line numberDiff line numberDiff line change
@@ -6577,17 +6577,17 @@ __metadata:
65776577
languageName: node
65786578
linkType: hard
65796579

6580-
"@metamask/solana-wallet-standard@npm:^0.3.0":
6581-
version: 0.3.1
6582-
resolution: "@metamask/solana-wallet-standard@npm:0.3.1"
6580+
"@metamask/solana-wallet-standard@npm:^0.4.1":
6581+
version: 0.4.1
6582+
resolution: "@metamask/solana-wallet-standard@npm:0.4.1"
65836583
dependencies:
65846584
"@solana/wallet-standard-chains": "npm:^1.1.1"
65856585
"@solana/wallet-standard-features": "npm:^1.3.0"
65866586
"@wallet-standard/base": "npm:^1.1.0"
65876587
"@wallet-standard/features": "npm:^1.1.0"
65886588
"@wallet-standard/wallet": "npm:^1.1.0"
65896589
bs58: "npm:^6.0.0"
6590-
checksum: 10/429a69cc5f040c1f22baf8c38fa4f9d07629d0b37fc343ae0175b282c80016c19e846462205aa584fb6cbfe9a56c06ef7bfffcc8236aceec921f934c41402f41
6590+
checksum: 10/dda61cc772c6e2ee2d43749b0c688714dce6ab722e6f213a810ecce0731cc45e5a9c4d74360240f1303d2deb0c4fb7c7b3d8dca316cd856465e3ce3ffeb57e90
65916591
languageName: node
65926592
linkType: hard
65936593

@@ -30070,7 +30070,7 @@ __metadata:
3007030070
"@metamask/snaps-sdk": "npm:^6.22.1"
3007130071
"@metamask/snaps-utils": "npm:^9.2.1"
3007230072
"@metamask/solana-wallet-snap": "npm:^1.24.0"
30073-
"@metamask/solana-wallet-standard": "npm:^0.3.0"
30073+
"@metamask/solana-wallet-standard": "npm:^0.4.1"
3007430074
"@metamask/test-bundler": "npm:^1.0.0"
3007530075
"@metamask/test-dapp": "npm:9.3.0"
3007630076
"@metamask/test-dapp-multichain": "npm:^0.10.0"

0 commit comments

Comments
 (0)