Skip to content

Add TypeScript guideline for minimizing selector input types #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2025
Merged

Add TypeScript guideline for minimizing selector input types #140

merged 5 commits into from
Apr 28, 2025

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift self-assigned this Apr 15, 2025
@MajorLift MajorLift requested a review from dbrans April 15, 2025 16:30
@MajorLift MajorLift requested a review from davidmurdoch April 15, 2025 16:32
@MajorLift MajorLift marked this pull request as ready for review April 15, 2025 16:35
@MajorLift MajorLift requested a review from a team as a code owner April 15, 2025 16:35
@MajorLift MajorLift requested a review from DDDDDanica April 15, 2025 16:35
@MajorLift MajorLift changed the title Add guideline to TypeScript article for minimizing selector input types Add TypeScript guideline for minimizing selector input types Apr 15, 2025
davidmurdoch
davidmurdoch reviewed Apr 15, 2025
View reviewed changes
@Mamonaminyar Mamonaminyar mentioned this pull request Apr 23, 2025
Open
cryptodev-2s
cryptodev-2s approved these changes Apr 27, 2025
View reviewed changes
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MajorLift MajorLift merged commit 854942a into main Apr 28, 2025
7 checks passed
@MajorLift MajorLift deleted the jongsun/typescript/250414-minimal-selector-types branch April 28, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmurdoch davidmurdoch davidmurdoch left review comments

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@GlaudineR GlaudineR GlaudineR approved these changes

@dbrans dbrans Awaiting requested review from dbrans

@DDDDDanica DDDDDanica Awaiting requested review from DDDDDanica

Assignees

@MajorLift MajorLift

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add guideline to TypeScript article regarding selector typing
4 participants
@MajorLift @davidmurdoch @cryptodev-2s @GlaudineR