-
Notifications
You must be signed in to change notification settings - Fork 80
Coin selection #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Coin selection #482
+14,855
−5,452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # package-lock.json # packages/mesh-common/src/types/transaction-builder/index.ts # packages/mesh-core-cst/src/types/cardano-sdk.ts # packages/mesh-transaction/package.json
# Conflicts: # package-lock.json # packages/mesh-core-csl/test/core/builder.test.ts # packages/mesh-core-cst/src/serializer/index.ts # packages/mesh-core-cst/src/utils/script-data-hash.ts # packages/mesh-transaction/package.json # packages/mesh-transaction/src/mesh-tx-builder/index.ts
twwu123
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies and improves the UTxO selection process in MeshSDK by implementing a more robust coin selection algorithm using Cardano SDK's input selection library. The changes remove the need for explicit selection strategy parameters and replace the previous selection mechanism with a more sophisticated approach. Key improvements include better handling of token bundles, reference scripts, complex UTxO scenarios, and automated fee calculation.
Affect components
@meshsdk/common
@meshsdk/contract
@meshsdk/core
@meshsdk/core-csl
@meshsdk/core-cst
@meshsdk/hydra
@meshsdk/provider
@meshsdk/react
@meshsdk/svelte
@meshsdk/transaction
@meshsdk/wallet
Type of Change
Related Issues
N/A
Checklist
npm run test
)npm run build
)Additional Information
This PR introduces a significant improvement to the UTxO selection process in MeshSDK by implementing Cardano SDK's input selection algorithm. The main changes are:
Simplified API: The
.selectUtxosFrom()
method no longer requires strategy, threshold, or includeTxFees parameters, making it easier to use.Breaking changes:
.selectUtxosFrom()
methodMeshTxBuilderBody
type to include additional fields for transaction constructionNew features:
Bug fixes: