-
-
Notifications
You must be signed in to change notification settings - Fork 687
chore: update PraisonAI version to 2.2.24 across Dockerfiles and docu… #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mentation - Updated the version of PraisonAI from 2.2.23 to 2.2.24 in all relevant Dockerfiles. - Adjusted version references in README.md and various documentation files. - Ensured consistency in package versioning for improved stability and performance.
✅ Deploy Preview for praisonai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Warning Rate limit exceeded@MervinPraison has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 54 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (13)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @MervinPraison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello team, gemini-code-assist here to provide a summary of this pull request. This PR primarily focuses on updating version references for the praisonai
and praisonaiagents
packages across the repository. The main goal is to bump the praisonai
version from 2.2.23
to 2.2.24
and the praisonaiagents
version from 0.0.94
to 0.0.95
in various configuration files, Dockerfiles, documentation, and dependency lock files to ensure consistency and incorporate the latest changes from these packages.
Highlights
- Version Updates: The core change involves updating the required versions of the
praisonai
package to2.2.24
and thepraisonaiagents
package to0.0.95
. - Dockerfile Updates: All relevant Dockerfiles (
Dockerfile
,Dockerfile.chat
,Dockerfile.dev
,Dockerfile.ui
) have been updated to installpraisonai
with a minimum version of2.2.24
. - Documentation Sync: Documentation files (
docker/README.md
,docs/api/praisonai/deploy.html
,docs/developers/local-development.mdx
,docs/ui/chat.mdx
,docs/ui/code.mdx
) have been updated to reflect the new2.2.24
version in examples and package lists. - Dependency Management Files: The
pyproject.toml
anduv.lock
files for bothpraisonai
andpraisonaiagents
have been updated to reflect the new package versions and their dependencies/hashes. - Homebrew Formula: The Homebrew formula (
src/praisonai/praisonai.rb
) has been updated to point to thev2.2.24
tag and includes the new SHA256 hash.
Changelog
Click here to see the changelog
- docker/Dockerfile
- Updated
praisonai
version constraint from>=2.2.23
to>=2.2.24
(line 19).
- Updated
- docker/Dockerfile.chat
- Updated
praisonai
version constraint from>=2.2.23
to>=2.2.24
(line 19).
- Updated
- docker/Dockerfile.dev
- Updated
praisonai
version constraint from>=2.2.23
to>=2.2.24
(line 23).
- Updated
- docker/Dockerfile.ui
- Updated
praisonai
version constraint from>=2.2.23
to>=2.2.24
(line 19).
- Updated
- docker/README.md
- Updated PraisonAI version reference from
>=2.2.23
to>=2.2.24
in the Package Versions section (line 124). - Updated PraisonAI version from
==2.2.23
to==2.2.24
in the Version Pinning example (line 221).
- Updated PraisonAI version reference from
- docs/api/praisonai/deploy.html
- Updated
praisonai
version from==2.2.23
to==2.2.24
in the embedded Dockerfile example (line 113).
- Updated
- docs/developers/local-development.mdx
- Updated
praisonai
version from==2.2.23
to==2.2.24
in the Dockerfile example (line 30).
- Updated
- docs/ui/chat.mdx
- Updated
praisonai
version from==2.2.23
to==2.2.24
in the Dockerfile example (line 158).
- Updated
- docs/ui/code.mdx
- Updated
praisonai
version from==2.2.23
to==2.2.24
in the Dockerfile example (line 211).
- Updated
- src/praisonai-agents/pyproject.toml
- Updated
praisonaiagents
version from0.0.94
to0.0.95
(line 7).
- Updated
- src/praisonai-agents/uv.lock
- Updated
praisonaiagents
version from0.0.94
to0.0.95
and updated associated URL/hashes (line 2236).
- Updated
- src/praisonai/praisonai.rb
- Updated Homebrew formula URL and SHA256 hash to reference
v2.2.24
(lines 6-7).
- Updated Homebrew formula URL and SHA256 hash to reference
- src/praisonai/praisonai/deploy.py
- Updated generated Dockerfile content to use
praisonai==2.2.24
(line 59).
- Updated generated Dockerfile content to use
- src/praisonai/pyproject.toml
- Updated
PraisonAI
project version from2.2.23
to2.2.24
(line 3). - Updated
praisonaiagents
dependency constraint from>=0.0.94
to>=0.0.95
(line 15). - Updated
PraisonAI
poetry version from2.2.23
to2.2.24
(line 98). - Updated
praisonaiagents
poetry dependency constraint from>=0.0.94
to>=0.0.95
(line 116).
- Updated
- src/praisonai/uv.lock
- Updated
praisonai
version from2.2.23
to2.2.24
(line 3934). - Updated
praisonaiagents
version from0.0.94
to0.0.95
(line 4076). - Updated
praisonaiagents
version from0.0.94
to0.0.95
and updated associated URL/hashes (line 4133).
- Updated
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Versions tick and climb,
From point to point through time,
Docker builds anew,
Docs reflect what's true,
Code aligned, a perfect rhyme.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively updates the PraisonAI version to 2.2.24 and praisonaiagents to 0.0.95 across various Dockerfiles, documentation, and configuration files. The changes are largely consistent and address the core goal of this version bump.
I've identified a couple of areas for improvement: one related to the security and reproducibility of the Homebrew formula and another concerning documentation consistency in docker/README.md
. Addressing these will enhance the quality and reliability of the codebase. Details are in the specific comments.
Summary of Findings
- Homebrew Formula SHA256 Calculation: The
praisonai.rb
Homebrew formula dynamically calculates the SHA256 checksum at install time. This is not a best practice and can lead to security vulnerabilities if the upstream tarball changes for the same tag. It's recommended to hardcode the SHA256 sum. - Documentation Inconsistency for PraisonAI Agents Version: The
docker/README.md
file listsPraisonAI Agents: >=0.0.92
, but thepraisonaiagents
package has been updated to0.0.95
elsewhere in the codebase. This documentation should be updated for consistency.
Merge Readiness
The pull request makes necessary version updates across the project. However, there's a high-severity issue regarding the SHA256 calculation in the Homebrew formula and a medium-severity documentation inconsistency. I recommend addressing these issues before merging to ensure security, reproducibility, and accuracy. As a reviewer, I am not authorized to approve the pull request; please ensure these changes are reviewed and approved by the appropriate maintainers after the suggested modifications are made.
url "https://github.com/MervinPraison/PraisonAI/archive/refs/tags/v2.2.23.tar.gz" | ||
sha256 `curl -sL https://github.com/MervinPraison/PraisonAI/archive/refs/tags/v2.2.23.tar.gz | shasum -a 256`.split.first | ||
url "https://github.com/MervinPraison/PraisonAI/archive/refs/tags/v2.2.24.tar.gz" | ||
sha256 `curl -sL https://github.com/MervinPraison/PraisonAI/archive/refs/tags/v2.2.24.tar.gz | shasum -a 256`.split.first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dynamically calculating the sha256
hash at install time using curl
can introduce potential security and reproducibility issues. If the content at the tag URL were to change (e.g., if the tag v2.2.24
was force-pushed with different content), this formula would download the new content without a fixed checksum verification.
Homebrew best practices recommend hardcoding the sha256
sum for a release tarball. This ensures that users always get the intended, verified bits for a specific version.
Could you consider calculating the SHA256 sum of the v2.2.24.tar.gz
release artifact once and hardcoding it here?
For example:
- Download the tarball:
curl -sLO https://github.com/MervinPraison/PraisonAI/archive/refs/tags/v2.2.24.tar.gz
- Calculate its SHA256 sum:
shasum -a 256 v2.2.24.tar.gz
- Replace this line with the hardcoded hash, e.g.,
sha256 "actual_calculated_hash_here"
.
sha256 "PUT_CALCULATED_SHA256_HASH_HERE" # Please calculate and replace this placeholder
@@ -121,7 +121,7 @@ healthcheck: | |||
## 📦 Package Versions | |||
|
|||
All Docker images use consistent, up-to-date versions: | |||
- PraisonAI: `>=2.2.23` | |||
- PraisonAI: `>=2.2.24` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PraisonAI version here!
It looks like the praisonaiagents
package was updated to 0.0.95
in this PR (e.g., in src/praisonai-agents/pyproject.toml
and as a dependency in src/praisonai/pyproject.toml
).
For consistency with the PR's goal to ensure consistent package versioning, should the PraisonAI Agents
version listed on the next line (line 125) in this README also be updated from >=0.0.92
to reflect the new version, perhaps to >=0.0.95
?
…mentation