STAB-838: mention temporal in connection error messages #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STAB-848 reported that, if e.g. the temporal server isn't running, the client logs
Error: TonicTransportError(tonic::transport::Error(Transport, ConnectError(ConnectError("tcp connect error", Os { code: 111, kind: ConnectionRefused, message: "Connection refused" }))))
without explicitly saying what it's trying to connect to.tracing through what happens here:
sdk-core
returns aClinitInitError
, which is an enum wrapping other errors, some of which wrap yet other errorsError: TonicTransportError
message users see) and then forward it on (but replacing the concrete error type with a string representation of it)config/settings.yml
), and then eventually throw aClientConnectionError
if the retries are exhaustedwhat this looks like for a user is:

i think simply prepending the error messages with
Error connecting to Temporal server:
is the simplest solution here