Skip to content

Add SimSun into font table #256 #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions R/content_create.R
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,14 @@ as_rtf_init <- function() {
#' @noRd
as_rtf_font <- function() {
font_type <- font_type()
font_rtf <- factor(c(1:10), levels = font_type$type, labels = font_type$rtf_code)
font_style <- factor(c(1:10), levels = font_type$type, labels = font_type$style)
font_name <- factor(c(1:10), levels = font_type$type, labels = font_type$name)
font_rtf <- factor(seq_along(font_type$type), levels = font_type$type, labels = font_type$rtf_code)
font_style <- factor(seq_along(font_type$type), levels = font_type$type, labels = font_type$style)
font_name <- factor(seq_along(font_type$type), levels = font_type$type, labels = font_type$name)
font_charset <- factor(seq_along(font_type$type), levels = font_type$type, labels = font_type$charset)

font_table <- paste0(
"{\\fonttbl",
paste(paste0("{", font_rtf, font_style, "\\fcharset161\\fprq2 ", font_name, ";}\n"), collapse = ""),
paste(paste0("{", font_rtf, font_style, font_charset, "\\fprq2 ", font_name, ";}\n"), collapse = ""),
"}\n"
)

Expand Down
11 changes: 6 additions & 5 deletions R/dictionary.R
Original file line number Diff line number Diff line change
Expand Up @@ -32,26 +32,27 @@
#' @noRd
font_type <- function() {
data.frame(
type = 1:10,
type = 1:11,
name = c(
"Times New Roman", "Times New Roman Greek", "Arial Greek",
"Arial", "Helvetica", "Calibri", "Georgia",
"Cambria", "Courier New", "Symbol"
"Cambria", "Courier New", "Symbol", "SimSun"
),
style = c(
"\\froman", "\\froman", "\\fswiss",
"\\fswiss", "\\fswiss", "\\fswiss", "\\froman",
"\\ffroman", "\\fmodern", "\\ftech"
"\\ffroman", "\\fmodern", "\\ftech", "\\fnil"
),
rtf_code = c(
"\\f0", "\\f1", "\\f2",
"\\f3", "\\f4", "\\f5", "\\f6",
"\\f7", "\\f8", "\\f9"
"\\f7", "\\f8", "\\f9", "\\f10"
),
family = c(
"Times", "Times", "ArialMT", "ArialMT", "Helvetica",
"Calibri", "Georgia", "Cambria", "Courier", "Times"
"Calibri", "Georgia", "Cambria", "Courier", "Times", "Times"
),
charset = c(rep("\\fcharset161", 10), "\\fcharset134"),
stringsAsFactors = FALSE
)
}
Expand Down
2 changes: 1 addition & 1 deletion R/rtf_strwidth.R
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ rtf_strwidth <- function(tbl) {
font_num <- as.numeric(attr(tbl, "text_font"))

# Group font with same style
font_num <- factor(font_num, levels = 1:10, labels = c(1, 1, 4, 4, 4, 1, 9, 4, 9, 9))
font_num <- factor(font_num, levels = 1:11, labels = c(1, 1, 4, 4, 4, 1, 9, 4, 9, 9, 1))
font_num <- as.numeric(as.character(font_num))

text_family <- font_type()[font_num, "family"]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# RTF font type encode

[1] "{\\fonttbl{\\f0\\froman\\fcharset161\\fprq2 Times New Roman;}\n{\\f1\\froman\\fcharset161\\fprq2 Times New Roman Greek;}\n{\\f2\\fswiss\\fcharset161\\fprq2 Arial Greek;}\n{\\f3\\fswiss\\fcharset161\\fprq2 Arial;}\n{\\f4\\fswiss\\fcharset161\\fprq2 Helvetica;}\n{\\f5\\fswiss\\fcharset161\\fprq2 Calibri;}\n{\\f6\\froman\\fcharset161\\fprq2 Georgia;}\n{\\f7\\ffroman\\fcharset161\\fprq2 Cambria;}\n{\\f8\\fmodern\\fcharset161\\fprq2 Courier New;}\n{\\f9\\ftech\\fcharset161\\fprq2 Symbol;}\n}\n"
[1] "{\\fonttbl{\\f0\\froman\\fcharset161\\fprq2 Times New Roman;}\n{\\f1\\froman\\fcharset161\\fprq2 Times New Roman Greek;}\n{\\f2\\fswiss\\fcharset161\\fprq2 Arial Greek;}\n{\\f3\\fswiss\\fcharset161\\fprq2 Arial;}\n{\\f4\\fswiss\\fcharset161\\fprq2 Helvetica;}\n{\\f5\\fswiss\\fcharset161\\fprq2 Calibri;}\n{\\f6\\froman\\fcharset161\\fprq2 Georgia;}\n{\\f7\\ffroman\\fcharset161\\fprq2 Cambria;}\n{\\f8\\fmodern\\fcharset161\\fprq2 Courier New;}\n{\\f9\\ftech\\fcharset161\\fprq2 Symbol;}\n{\\f10\\fnil\\fcharset134\\fprq2 SimSun;}\n}\n"

# RTF font color encode with color not NULL

Expand Down
23 changes: 12 additions & 11 deletions tests/testthat/_snaps/independent-testing-dictionary.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
# text font

type name style rtf_code family
1 1 Times New Roman \\froman \\f0 Times
2 2 Times New Roman Greek \\froman \\f1 Times
3 3 Arial Greek \\fswiss \\f2 ArialMT
4 4 Arial \\fswiss \\f3 ArialMT
5 5 Helvetica \\fswiss \\f4 Helvetica
6 6 Calibri \\fswiss \\f5 Calibri
7 7 Georgia \\froman \\f6 Georgia
8 8 Cambria \\ffroman \\f7 Cambria
9 9 Courier New \\fmodern \\f8 Courier
10 10 Symbol \\ftech \\f9 Times
type name style rtf_code family charset
1 1 Times New Roman \\froman \\f0 Times \\fcharset161
2 2 Times New Roman Greek \\froman \\f1 Times \\fcharset161
3 3 Arial Greek \\fswiss \\f2 ArialMT \\fcharset161
4 4 Arial \\fswiss \\f3 ArialMT \\fcharset161
5 5 Helvetica \\fswiss \\f4 Helvetica \\fcharset161
6 6 Calibri \\fswiss \\f5 Calibri \\fcharset161
7 7 Georgia \\froman \\f6 Georgia \\fcharset161
8 8 Cambria \\ffroman \\f7 Cambria \\fcharset161
9 9 Courier New \\fmodern \\f8 Courier \\fcharset161
10 10 Symbol \\ftech \\f9 Times \\fcharset161
11 11 SimSun \\fnil \\f10 Times \\fcharset134

# border type

Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/_snaps/independent-testing-rtf_encode.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Test if content is converted to RTF correctly when tbl class is list

$start
[1] "{\\rtf1\\ansi\n\\deff0\\deflang1033\n{\\fonttbl{\\f0\\froman\\fcharset161\\fprq2 Times New Roman;}\n{\\f1\\froman\\fcharset161\\fprq2 Times New Roman Greek;}\n{\\f2\\fswiss\\fcharset161\\fprq2 Arial Greek;}\n{\\f3\\fswiss\\fcharset161\\fprq2 Arial;}\n{\\f4\\fswiss\\fcharset161\\fprq2 Helvetica;}\n{\\f5\\fswiss\\fcharset161\\fprq2 Calibri;}\n{\\f6\\froman\\fcharset161\\fprq2 Georgia;}\n{\\f7\\ffroman\\fcharset161\\fprq2 Cambria;}\n{\\f8\\fmodern\\fcharset161\\fprq2 Courier New;}\n{\\f9\\ftech\\fcharset161\\fprq2 Symbol;}\n}\n\n"
[1] "{\\rtf1\\ansi\n\\deff0\\deflang1033\n{\\fonttbl{\\f0\\froman\\fcharset161\\fprq2 Times New Roman;}\n{\\f1\\froman\\fcharset161\\fprq2 Times New Roman Greek;}\n{\\f2\\fswiss\\fcharset161\\fprq2 Arial Greek;}\n{\\f3\\fswiss\\fcharset161\\fprq2 Arial;}\n{\\f4\\fswiss\\fcharset161\\fprq2 Helvetica;}\n{\\f5\\fswiss\\fcharset161\\fprq2 Calibri;}\n{\\f6\\froman\\fcharset161\\fprq2 Georgia;}\n{\\f7\\ffroman\\fcharset161\\fprq2 Cambria;}\n{\\f8\\fmodern\\fcharset161\\fprq2 Courier New;}\n{\\f9\\ftech\\fcharset161\\fprq2 Symbol;}\n{\\f10\\fnil\\fcharset134\\fprq2 SimSun;}\n}\n\n"

$body
[1] "\\paperw12240\\paperh15840\n\n\\margl1800\\margr1440\\margt2520\\margb1800\\headery2520\\footery1449\n\n\n\n\n\\trowd\\trgaph108\\trleft0\\trqc\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrdb\\brdrw15\\clbrdrr\\brdrs\\brdrw15\\clbrdrb\\brdrw15\\clvertalb\\cellx9000\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 X1}\\cell\n\\intbl\\row\\pard\n\\trowd\\trgaph108\\trleft0\\trqc\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrs\\brdrw15\\clbrdrr\\brdrs\\brdrw15\\clbrdrb\\brdrs\\brdrw15\\clvertalt\\cellx9000\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 1}\\cell\n\\intbl\\row\\pard\n\n\n\n\n\\paperw12240\\paperh15840\n\n\\margl1800\\margr1440\\margt2520\\margb1800\\headery2520\\footery1449\n\n\n\n\n\\trowd\\trgaph108\\trleft0\\trqc\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrs\\brdrw15\\clbrdrr\\brdrs\\brdrw15\\clbrdrb\\brdrw15\\clvertalb\\cellx9000\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 X1}\\cell\n\\intbl\\row\\pard\n\\trowd\\trgaph108\\trleft0\\trqc\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrs\\brdrw15\\clbrdrr\\brdrs\\brdrw15\\clbrdrb\\brdrdb\\brdrw15\\clvertalt\\cellx9000\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 1}\\cell\n\\intbl\\row\\pard\n\n\n\n"
Expand All @@ -13,7 +13,7 @@
# Test if content is converted to RTF correctly when tbl class is data.frame

$start
[1] "{\\rtf1\\ansi\n\\deff0\\deflang1033\n{\\fonttbl{\\f0\\froman\\fcharset161\\fprq2 Times New Roman;}\n{\\f1\\froman\\fcharset161\\fprq2 Times New Roman Greek;}\n{\\f2\\fswiss\\fcharset161\\fprq2 Arial Greek;}\n{\\f3\\fswiss\\fcharset161\\fprq2 Arial;}\n{\\f4\\fswiss\\fcharset161\\fprq2 Helvetica;}\n{\\f5\\fswiss\\fcharset161\\fprq2 Calibri;}\n{\\f6\\froman\\fcharset161\\fprq2 Georgia;}\n{\\f7\\ffroman\\fcharset161\\fprq2 Cambria;}\n{\\f8\\fmodern\\fcharset161\\fprq2 Courier New;}\n{\\f9\\ftech\\fcharset161\\fprq2 Symbol;}\n}\n\n"
[1] "{\\rtf1\\ansi\n\\deff0\\deflang1033\n{\\fonttbl{\\f0\\froman\\fcharset161\\fprq2 Times New Roman;}\n{\\f1\\froman\\fcharset161\\fprq2 Times New Roman Greek;}\n{\\f2\\fswiss\\fcharset161\\fprq2 Arial Greek;}\n{\\f3\\fswiss\\fcharset161\\fprq2 Arial;}\n{\\f4\\fswiss\\fcharset161\\fprq2 Helvetica;}\n{\\f5\\fswiss\\fcharset161\\fprq2 Calibri;}\n{\\f6\\froman\\fcharset161\\fprq2 Georgia;}\n{\\f7\\ffroman\\fcharset161\\fprq2 Cambria;}\n{\\f8\\fmodern\\fcharset161\\fprq2 Courier New;}\n{\\f9\\ftech\\fcharset161\\fprq2 Symbol;}\n{\\f10\\fnil\\fcharset134\\fprq2 SimSun;}\n}\n\n"

$body
[1] "\\paperw12240\\paperh15840\n\n\\margl1800\\margr1440\\margt2520\\margb1800\\headery2520\\footery1449\n\n\n\n\n\\trowd\\trgaph108\\trleft0\\trqc\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrdb\\brdrw15\\clbrdrb\\brdrw15\\clvertalb\\cellx1800\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrdb\\brdrw15\\clbrdrb\\brdrw15\\clvertalb\\cellx3600\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrdb\\brdrw15\\clbrdrb\\brdrw15\\clvertalb\\cellx5400\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrdb\\brdrw15\\clbrdrb\\brdrw15\\clvertalb\\cellx7200\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrdb\\brdrw15\\clbrdrr\\brdrs\\brdrw15\\clbrdrb\\brdrw15\\clvertalb\\cellx9000\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 Sepal.Length}\\cell\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 Sepal.Width}\\cell\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 Petal.Length}\\cell\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 Petal.Width}\\cell\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 Species}\\cell\n\\intbl\\row\\pard\n\\trowd\\trgaph108\\trleft0\\trqc\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrs\\brdrw15\\clbrdrb\\brdrw15\\clvertalt\\cellx1800\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrs\\brdrw15\\clbrdrb\\brdrw15\\clvertalt\\cellx3600\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrs\\brdrw15\\clbrdrb\\brdrw15\\clvertalt\\cellx5400\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrs\\brdrw15\\clbrdrb\\brdrw15\\clvertalt\\cellx7200\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrs\\brdrw15\\clbrdrr\\brdrs\\brdrw15\\clbrdrb\\brdrw15\\clvertalt\\cellx9000\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 5.1}\\cell\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 3.5}\\cell\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 1.4}\\cell\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 0.2}\\cell\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 setosa}\\cell\n\\intbl\\row\\pard\n\\trowd\\trgaph108\\trleft0\\trqc\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrw15\\clbrdrb\\brdrdb\\brdrw15\\clvertalt\\cellx1800\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrw15\\clbrdrb\\brdrdb\\brdrw15\\clvertalt\\cellx3600\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrw15\\clbrdrb\\brdrdb\\brdrw15\\clvertalt\\cellx5400\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrw15\\clbrdrb\\brdrdb\\brdrw15\\clvertalt\\cellx7200\n\\clbrdrl\\brdrs\\brdrw15\\clbrdrt\\brdrw15\\clbrdrr\\brdrs\\brdrw15\\clbrdrb\\brdrdb\\brdrw15\\clvertalt\\cellx9000\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 4.9}\\cell\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 3}\\cell\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 1.4}\\cell\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 0.2}\\cell\n\\pard\\hyphpar0\\sb15\\sa15\\fi0\\li0\\ri0\\qc\\fs18{\\f0 setosa}\\cell\n\\intbl\\row\\pard\n\n\n"
Expand Down
6 changes: 3 additions & 3 deletions tests/testthat/_snaps/independent-testing-rtf_encode_list.md

Large diffs are not rendered by default.

Loading