Skip to content

Fix SendApplicationAnswerMailHandler not supplying enough parameters #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

BentiGorlich
Copy link
Member

SendApplicationAnswerMailHandler was not supplying the kernel interface parameter to the base class, fix that

- SendApplicationAnswerMailHandler was not supplying the kernel interface parameter to the base class, fix that
@BentiGorlich BentiGorlich added bug Something isn't working backend Backend related issues and pull requests high priority critical issue or PR that impacts production labels Mar 31, 2025
@BentiGorlich BentiGorlich requested a review from melroy89 March 31, 2025 17:07
@BentiGorlich BentiGorlich self-assigned this Mar 31, 2025
@BentiGorlich
Copy link
Member Author

I looked through all the message handlers and could not find another one missing the second parameter

@melroy89
Copy link
Member

melroy89 commented Mar 31, 2025

I think this was not the first similar error we discovered. So I'm saying this is the second time we found this bug exact bug.

Q: Is it possible to find any remaining issues in the code base? Maybe some intelligent PHP analyzer tool or something? Since we also have no way of knowing when this could happen again, all the tests are passing as well. Including Psalm before the issue is fixed in this PR I mean.

@BentiGorlich
Copy link
Member Author

I searched for it with a reference search in PHPStorm, I don't think that we can search more in depth than that. I think we had this problem before, but with a different message handler. I think the problem was that the message handler adaption was being done at the same time as this handler was introduced and then it was just forgotten...

@BentiGorlich BentiGorlich merged commit 68617c9 into main Apr 1, 2025
7 checks passed
@BentiGorlich BentiGorlich deleted the fix/message-handler-too-few-arguments branch April 1, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related issues and pull requests bug Something isn't working high priority critical issue or PR that impacts production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants