Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix period in remote usernames #1533

Merged
merged 2 commits into from
Mar 30, 2025
Merged

Fix period in remote usernames #1533

merged 2 commits into from
Mar 30, 2025

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Mar 30, 2025 •
edited
Loading

  • Fix period in remote usernames (\w for word, will not cut it), since some Fediverse software allows @user.name, for example, as a valid username)
  • Removing the arbitrary 30 char limit as well
  • Add code documentation

I tested it regex again with https://regex101.com/

@melroy89 melroy89 added the enhancement New feature or request label Mar 30, 2025
@melroy89 melroy89 added this to the v1.8.1 milestone Mar 30, 2025
@melroy89 melroy89 requested review from BentiGorlich and jwr1 March 30, 2025 16:21
@melroy89 melroy89 mentioned this pull request Mar 30, 2025
Closed
jwr1
jwr1 approved these changes Mar 30, 2025
View reviewed changes
Copy link
Member

@jwr1 jwr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good.

@melroy89 melroy89 merged commit b800eae into main Mar 30, 2025
7 checks passed
@melroy89 melroy89 deleted the fix_period_in_remote_usernames branch March 30, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwr1 jwr1 jwr1 approved these changes

@BentiGorlich BentiGorlich Awaiting requested review from BentiGorlich

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@melroy89 @jwr1