-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend public access roles for three API end-points #1487
Conversation
Co-authored-by: BentiGorlich <[email protected]>
maybe also add the federated and dead routes? |
yes I think so as well. |
Your review is now auto dismissed 😢 |
So, then should we make the corresponding web pages public as well? Like the about, privacy policy, faq, terms, federation page, etc. |
Some of these makes sense yes. Especially about, privacy policy, and terms. |
Well, all the ones I listed are now public through the API, right? So, the corresponding web pages should be made public as well. |
Yes, only as long as there is a Twig caching in place for these pages. So the impact on the server-side should be minimal. |
When the server is in "Force users to login before they can access any content" mode, still allow the following 3 API end-points to be accessible for requests. Which is also used for: https://joinmbin.org/servers
/api/info
/api/instance
/api/defederate