Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some opcache and composer optimizations #1460

Merged
merged 6 commits into from
Feb 17, 2025

Conversation

BentiGorlich
Copy link
Member

  • add opcache preload to docs and docker config
  • add disable opcache timestamp validation in docs and docker config
  • enable composers authoritative classmap

@BentiGorlich BentiGorlich added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Feb 17, 2025
@BentiGorlich BentiGorlich self-assigned this Feb 17, 2025
- add opcache preload to docs and docker config
- add disable opcache timestamp validation in docs and docker config
- enable composers authoritative classmap
@BentiGorlich BentiGorlich force-pushed the new/opcache-and-compose-optimizations branch from d369e85 to ecb07d8 Compare February 17, 2025 14:43
Copy link
Member

@melroy89 melroy89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owh. We should also update the docs for opcache.preload=/var/www/mbin/config/preload.php

@BentiGorlich
Copy link
Member Author

Owh. We should also update the docs for opcache.preload=/var/www/mbin/config/preload.php

What do you mean?

@melroy89
Copy link
Member

melroy89 commented Feb 17, 2025

sorry I wasn't clear, yes you updated the docs already. I mean, I think we should add a small remark, that in case the server use the same PHP FPM for other websites as well, this preload will most likely cause issues on other sites.

@melroy89
Copy link
Member

I think we should add a small remark, that in case the server use the same PHP FPM for other websites as well, this preload will most likely cause issues on other sites.

Which I can confirm myself with Nextcloud for example.

@BentiGorlich
Copy link
Member Author

I thought that that is just the preload and there can always only be one preload... But not that it would cause issues with other websites...

@melroy89
Copy link
Member

I thought that that is just the preload and there can always only be one preload... But not that it would cause issues with other websites...

Here is your proof:

Fatal error: Cannot redeclare Aws\constantly() (previously declared in /var/www/kbin.melroy.org/html/vendor/aws/aws-sdk-php/src/functions.php:20) in /var/www/nextcloud/html/3rdparty/aws/aws-sdk-php/src/functions.php on line 20

@BentiGorlich
Copy link
Member Author

oooooohhhhhhhh

@BentiGorlich BentiGorlich enabled auto-merge (squash) February 17, 2025 15:20
@BentiGorlich BentiGorlich merged commit c66fd5e into main Feb 17, 2025
7 checks passed
@BentiGorlich BentiGorlich deleted the new/opcache-and-compose-optimizations branch February 17, 2025 15:32
@melroy89
Copy link
Member

melroy89 commented Feb 17, 2025

See follow-up: #1463

@melroy89 melroy89 added this to the v1.8.1 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants