Skip to content

BigQuery: deprecate client.dataset() #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 95 commits into from
Closed

BigQuery: deprecate client.dataset() #27

wants to merge 95 commits into from

Conversation

IlyaFaer
Copy link
Collaborator

@IlyaFaer IlyaFaer commented Aug 9, 2019 •
edited by emar-kar
Loading

Towards: googleapis#8989
File's list:

  • add_empty_column
  • browse_table_data
  • client_list_jobs
  • client_query_add_column
  • client_query_batch
  • client_query_destination_table_cmek
  • client_query_destination_table_legacy
  • client_query_destination_table
  • client_query_dry_run
  • client_query_legacy_sql
  • client_query_relax_column
  • client_query_total_rows
  • client_query_w_array_params
  • client_query_w_named_params
  • client_query_w_positional_params
  • client_query_w_struct_params
  • client_query_w_timestamp_params
  • client_query
  • copy_table_cmek
  • copy_table_multiple_source
  • copy_table
  • create_client_default_credentials
  • create_dataset
  • create_partitioned_table
  • create_routine_ddl
  • create_routine
  • create_table_cmek
  • create_table_nested_repeated_schema
  • create_table
  • dataset_exists
  • ddl_create_view
  • delete_dataset
  • delete_model
  • delete_routine
  • delete_table
  • extract_table_compressed
  • extract_table_json
  • extract_table
  • get_dataset
  • get_model
  • get_routine
  • get_table
  • list_datasets_by_label
  • list_datasets
  • list_models
  • list_routines
  • list_rows_as_dataframe
  • list_tables
  • load_and_query_partitioned_table
    • load_partitioned_table
    • query_partitioned_table
  • load_table_add_column
  • load_table_from_dataframe
  • load_table_from_file
  • load_table_from_uri_autodetect
    • load_table_gcs_csv_autodetect
    • load_table_gcs_json_autodetect
  • load_table_from_uri_avro
  • load_table_from_uri_cmek
  • load_table_from_uri_csv
  • load_table_from_uri_json
  • load_table_from_uri_orc
  • load_table_from_uri_parquet
  • load_table_from_uri_truncate
    • load_table_gcs_avro_truncate
    • load_table_gcs_csv_truncate
    • load_table_gcs_json_truncate
    • load_table_gcs_orc_truncate
    • load_table_gcs_parquet_truncate
  • load_table_relax_column
  • manage_dataset_labels
    • label_dataset
    • get_dataset_labels
    • delete_dataset_labels
  • manage_job
    • create_job
    • get_job
    • cancel_job
  • manage_table_labels
    • label_table
    • get_table_labels
    • delete_table_labels
  • manage_views
    • grant_view_access
    • create_view
    • update_view_query
    • get_view
  • query_external_gcs_permanent_table
  • query_external_gcs_temporary_table
  • query_external_sheets_permanent_table
  • query_external_sheets_temporary_table
  • query_no_cache
  • query_results_as_dataframe
  • query_to_arrow
  • relax_column
  • table_exists
  • table_insert_rows
  • undelete_table
  • update_dataset_access
  • update_dataset_default_table_expiration
  • update_dataset_description
  • update_model
  • update_routine
  • update_table_cmek
  • update_table_description
  • update_table_expiration

@IlyaFaer
Copy link
Collaborator Author

IlyaFaer commented Aug 9, 2019

@emar-kar, okay, script made a lot of changes: created samples, test-file templates and updated rst-marking. Code itself still needs refactoring, but most part of monkey-work is done. Let's proceed in this branch

@emar-kar
list_datasets_by_label
377310c 
*.rst    +
*.py    +
test    +
conf   +
@emar-kar emar-kar changed the title Move every snippet to it's own file. Create test templates. BigQuery: deprecate client.dataset() Aug 9, 2019
@IlyaFaer
Copy link
Collaborator Author

IlyaFaer commented Aug 9, 2019

@tswast, we've tried to automate routine part of work, and got too many changes. We'll be staging- commiting-pushing them partially. Will be five snippets per PR convenient enough for you?

@tswast
Copy link

tswast commented Aug 9, 2019

Will be five snippets per PR convenient enough for you?

Yes, that'll be okay.

@emar-kar
manage_dataset_labels
a7b2376 
Methods were divided into 3 files:
- add label
- get labels
- delete labels

*.rst - docs updated
tests passed successfully
@emar-kar
add_empty_column
0de5d8b
@emar-kar
browse_table_data
5e05cd8
@emar-kar
dataset_exists
f6b60a0
@emar-kar
complete change of dataset_exists
a773251
@emar-kar emar-kar mentioned this pull request Aug 13, 2019
Closed
emar-kar added 13 commits August 13, 2019 13:31
@emar-kar
client_list_jobs
0645e33
@emar-kar
client_query
92efd59
@emar-kar
copy_table
1814821
@emar-kar
cosmetic chgs
a31bc1f
@emar-kar
Update datasets.rst
725c515 
minor corrections, 'dataset_exists' moved to the 'Getting a Dataset' section
@emar-kar
cosmetic chgs
6ffc123 
grammar fix
@emar-kar
table_exists
2ff376c
@emar-kar
Update test_copy_table.py
948ddb5 
minor corrections, removed extra comments
@emar-kar
Update test_table_exists.py
e8d62c4 
minor corrections, removed extra comments
@emar-kar
Update snippets.py
28251ec 
deleted 'dataset_exists' and 'table_exists' methods
@emar-kar
update client_list_jobs
ad623ba 
Added additional asserts into the test + refactoring of the main file.
@emar-kar
table_insert_rows
ec67aee
@emar-kar
Update client_query.py
c8c0f70 
cosmetic chgs by 'black'
@emar-kar emar-kar mentioned this pull request Aug 28, 2019
Closed
@emar-kar emar-kar mentioned this pull request Aug 29, 2019
Closed
@emar-kar emar-kar mentioned this pull request Aug 30, 2019
Closed
@emar-kar emar-kar mentioned this pull request Sep 2, 2019
Closed
@emar-kar emar-kar mentioned this pull request Sep 18, 2019
Closed
@emar-kar emar-kar closed this Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@IlyaFaer IlyaFaer

@emar-kar emar-kar

Labels
api: bigquery type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IlyaFaer @tswast @emar-kar @mf2199